Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes
Date	Mon, 22 Feb 2016 16:20:01 +0100
Message-ID	<r50rf-7B2-5@gated-at.bofh.it> (permalink)
References	<qUNvk-37P-3@gated-at.bofh.it> <qUNvm-37P-57@gated-at.bofh.it>
X-Original-To	"Suzuki K. Poulose" <suzuki.poulose@arm.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-kernel@lists.infradead.org, punit.agrawal@arm.com, arm@kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 22 Feb 2016 15:16:24 +0000
X-Original-Message-ID	<20160222151623.GH3435@leverpostej>
X-Original-References	<1453720877-24962-1-git-send-email-suzuki.poulose@arm.com> <1453720877-24962-11-git-send-email-suzuki.poulose@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1339622

Show key headers only | View raw

A couple more comments for things i just realised:

> +	/*
> +	 * Now that all the counters are disabled, we can safely turn the PMU on,
> +	 * without syncing the status of the counters
> +	 */
> +	__cci_pmu_enable(cci_pmu, CCI_CNTRS_NOSYNC);

As per my other comment, __cci_pmu_enable_nosync(cci_pmu) would be
preferable.

[...]

> +		pmu_write_counter(cci_pmu,
> +				  (u32)local64_read(&event->hw.prev_count), i);

That cast can go.

Mark.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes Mark Rutland <mark.rutland@arm.com> - 2016-02-22 16:20 +0100

csiph-web