Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes
Date	2016-02-22 16:20 +0100
Message-ID	<r50rf-7B2-5@gated-at.bofh.it> (permalink)
References	<qUNvk-37P-3@gated-at.bofh.it> <qUNvm-37P-57@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

A couple more comments for things i just realised:

> +	/*
> +	 * Now that all the counters are disabled, we can safely turn the PMU on,
> +	 * without syncing the status of the counters
> +	 */
> +	__cci_pmu_enable(cci_pmu, CCI_CNTRS_NOSYNC);

As per my other comment, __cci_pmu_enable_nosync(cci_pmu) would be
preferable.

[...]

> +		pmu_write_counter(cci_pmu,
> +				  (u32)local64_read(&event->hw.prev_count), i);

That cast can go.

Mark.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes Mark Rutland <mark.rutland@arm.com> - 2016-02-22 16:20 +0100

csiph-web