Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339622 > unrolled thread

Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes Mark Rutland <mark.rutland@arm.com> - 2016-02-22 16:20 +0100

#1339622 — Re: [PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes

A couple more comments for things i just realised:

> +	/*
> +	 * Now that all the counters are disabled, we can safely turn the PMU on,
> +	 * without syncing the status of the counters
> +	 */
> +	__cci_pmu_enable(cci_pmu, CCI_CNTRS_NOSYNC);

As per my other comment, __cci_pmu_enable_nosync(cci_pmu) would be
preferable.

[...]

> +		pmu_write_counter(cci_pmu,
> +				  (u32)local64_read(&event->hw.prev_count), i);

That cast can go.

Mark.

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web