RE: [PATCH 2/2] net, thunderx: Use bool in structs where possible

From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH 2/2] net, thunderx: Use bool in structs where possible
Date	2016-02-22 12:10 +0100
Message-ID	<r4Wxj-4RK-7@gated-at.bofh.it> (permalink)
References	<r3wlB-5Cm-7@gated-at.bofh.it> <r3wlB-5Cm-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Robert Richter
> Sent: 18 February 2016 12:39
> From: Robert Richter <rrichter@cavium.com>
> 
> Looks like the :1 notation was accidentally introduced (this still
> uses 1 byte per flag). Using bool instead, which is the common use.
> 
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
>  drivers/net/ethernet/cavium/thunder/nic.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/thunder/nic.h b/drivers/net/ethernet/cavium/thunder/nic.h
> index 688828865c48..fa5b1d2d8e23 100644
> --- a/drivers/net/ethernet/cavium/thunder/nic.h
> +++ b/drivers/net/ethernet/cavium/thunder/nic.h
> @@ -262,9 +262,9 @@ struct nicvf {
>  	struct pci_dev		*pdev;
>  	u8			vf_id;
>  	u8			node;
> -	u8			tns_mode:1;
> -	u8			sqs_mode:1;
> -	u8			loopback_supported:1;
> +	bool			tns_mode;
> +	bool                    sqs_mode;
> +	bool			loopback_supported;
>  	bool			hw_tso;
>  	u16			mtu;
>  	struct queue_set	*qs;

If the size of the structure matters, you've just made it two bytes larger.
(Although it looks like there is some padding).

	David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] net, thunderx: Use bool in structs where possible Robert Richter <rrichter@caviumnetworks.com> - 2016-02-18 14:00 +0100
  Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Miller <davem@davemloft.net> - 2016-02-18 17:10 +0100
    Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible Robert Richter <robert.richter@caviumnetworks.com> - 2016-02-18 17:50 +0100
      Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Miller <davem@davemloft.net> - 2016-02-18 21:10 +0100
  RE: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Laight <David.Laight@ACULAB.COM> - 2016-02-22 12:10 +0100

csiph-web