Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337663

Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

Show all headers | View raw

From: Robert Richter <robert.richter@caviumnetworks.com>
Date: Thu, 18 Feb 2016 17:42:17 +0100

> On 18.02.16 11:05:14, David Miller wrote:
>> From: Robert Richter <rrichter@caviumnetworks.com>
>> Date: Thu, 18 Feb 2016 13:39:09 +0100
>> 
>> > From: Robert Richter <rrichter@cavium.com>
>> > 
>> > Looks like the :1 notation was accidentally introduced (this still
>> > uses 1 byte per flag). Using bool instead, which is the common use.
>> > 
>> > Signed-off-by: Robert Richter <rrichter@cavium.com>
>> 
>> Such cleanups are not appropriate for 'net'.  Only real bug fixes should
>> be targetted that.
>> 
>> Respin these patches targetting the correct tree(s).
> 
> Do you mean posting the two as "trivial" patches?

No I mean posting #1 targetted at my 'net' GIT tree as a bug fix,
and posting #2 targetted separately at my 'net-next' GIT tree as
a cleanup.

This is how we've been doing things for more than a decade.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] net, thunderx: Use bool in structs where possible Robert Richter <rrichter@caviumnetworks.com> - 2016-02-18 14:00 +0100
  Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Miller <davem@davemloft.net> - 2016-02-18 17:10 +0100
    Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible Robert Richter <robert.richter@caviumnetworks.com> - 2016-02-18 17:50 +0100
      Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Miller <davem@davemloft.net> - 2016-02-18 21:10 +0100
  RE: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Laight <David.Laight@ACULAB.COM> - 2016-02-22 12:10 +0100

csiph-web