Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337330

[PATCH 2/2] net, thunderx: Use bool in structs where possible

From Robert Richter <rrichter@caviumnetworks.com>
Newsgroups linux.kernel
Subject [PATCH 2/2] net, thunderx: Use bool in structs where possible
Date 2016-02-18 14:00 +0100
Message-ID <r3wlB-5Cm-5@gated-at.bofh.it> (permalink)
References <r3wlB-5Cm-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: Robert Richter <rrichter@cavium.com>

Looks like the :1 notation was accidentally introduced (this still
uses 1 byte per flag). Using bool instead, which is the common use.

Signed-off-by: Robert Richter <rrichter@cavium.com>
---
 drivers/net/ethernet/cavium/thunder/nic.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/cavium/thunder/nic.h b/drivers/net/ethernet/cavium/thunder/nic.h
index 688828865c48..fa5b1d2d8e23 100644
--- a/drivers/net/ethernet/cavium/thunder/nic.h
+++ b/drivers/net/ethernet/cavium/thunder/nic.h
@@ -262,9 +262,9 @@ struct nicvf {
 	struct pci_dev		*pdev;
 	u8			vf_id;
 	u8			node;
-	u8			tns_mode:1;
-	u8			sqs_mode:1;
-	u8			loopback_supported:1;
+	bool			tns_mode;
+	bool                    sqs_mode;
+	bool			loopback_supported;
 	bool			hw_tso;
 	u16			mtu;
 	struct queue_set	*qs;
@@ -353,9 +353,9 @@ struct nic_cfg_msg {
 	u8    msg;
 	u8    vf_id;
 	u8    node_id;
-	u8    tns_mode:1;
-	u8    sqs_mode:1;
-	u8    loopback_supported:1;
+	bool  tns_mode;
+	bool  sqs_mode;
+	bool  loopback_supported;
 	u8    mac_addr[ETH_ALEN];
 };
 
-- 
2.7.0.rc3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] net, thunderx: Use bool in structs where possible Robert Richter <rrichter@caviumnetworks.com> - 2016-02-18 14:00 +0100
  Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Miller <davem@davemloft.net> - 2016-02-18 17:10 +0100
    Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible Robert Richter <robert.richter@caviumnetworks.com> - 2016-02-18 17:50 +0100
      Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Miller <davem@davemloft.net> - 2016-02-18 21:10 +0100
  RE: [PATCH 2/2] net, thunderx: Use bool in structs where possible David Laight <David.Laight@ACULAB.COM> - 2016-02-22 12:10 +0100

csiph-web