Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336693

Re: [PATCH] goldfish: Return proper error code

Show all headers | View raw

On Wed, 17 Feb 2016, One Thousand Gnomes wrote:

> On Wed, 17 Feb 2016 22:53:29 +0530
> Amitoj Kaur Chawla <amitoj1606@gmail.com> wrote:
>
> > This change has been made with the goal that kernel functions should
> > return something more descriptive than -1 on failure.
> >
> > Change the return value on valid_batchbuffer_addr() failure from -1
> > to -EINVAL.
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>
> NAK. It's not user visible, it's a piece of code that has a pile of other
> more important fixes needed first, and it's also as far as possible kept
> aligned with the Android upstream.
>
> If it were some random otherwise unchanging bit of code then it might
> just about make sense but in this case no - especially when you only
> change one of the two returns of -1 !

The other has been chahged already in a patch in the staging tree.  Maybe
it's not in linux-next yet?

julia

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] goldfish: Return proper error code Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-17 18:30 +0100
  Re: [PATCH] goldfish: Return proper error code One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-17 19:50 +0100
    Re: [PATCH] goldfish: Return proper error code Julia Lawall <julia.lawall@lip6.fr> - 2016-02-17 20:30 +0100
      Re: [PATCH] goldfish: Return proper error code Julia Lawall <julia.lawall@lip6.fr> - 2016-02-17 20:30 +0100

csiph-web