Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1336692
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON |
| Date | 2016-02-17 20:30 +0100 |
| Message-ID | <r3fXs-2qW-11@gated-at.bofh.it> (permalink) |
| References | <r3fb3-1S3-1@gated-at.bofh.it> <r3fuq-1YZ-17@gated-at.bofh.it> <r3fuq-1YZ-19@gated-at.bofh.it> <r3fNN-2nq-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Em Wed, Feb 17, 2016 at 08:15:35PM +0100, Andi Kleen escreveu: > On Wed, Feb 17, 2016 at 03:56:21PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Feb 17, 2016 at 03:52:09PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Feb 17, 2016 at 10:39:08AM -0800, Andi Kleen escreveu: > > > > In my set up (separate objdir, DEBUG=1) tip perf doesn't build without this change. > > > > It may be that in some other setups asm/bug.h is implicitely included. > > > > > Thanks, applying your fix, after making it build on acme/perf/core: > > > > I take that back, it is already there: > > Ok, but not in tip/perf/core. Can you push it there please? Huh? I can't, this is not my tree, its Ingo's. But lemme check there... [acme@jouet linux]$ git remote update tip Fetching tip remote: Counting objects: 13, done. remote: Compressing objects: 100% (13/13), done. remote: Total 13 (delta 11), reused 0 (delta 0) Unpacking objects: 100% (13/13), done. From git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 5eaa0c926246..d7c926f699aa master -> tip/master + e2c90dd7e11e...65c23c65bee4 x86/efi -> tip/x86/efi (forced update) 605a46ee8353..8f8e2aec9944 x86/platform -> tip/x86/platform [acme@jouet linux]$ git checkout -b aktest tip/perf/core Branch aktest set up to track remote branch perf/core from tip. Switched to a new branch 'aktest' [acme@jouet linux]$ git blame tools/perf/builtin-stat.c | grep -w bug\.h ba6039b6c8fcc tools/perf/builtin-stat.c (Jiri Olsa 2015-11-05 15:40:55 +0100 64) #include "asm/bug.h" [acme@jouet linux]$ git remote -v | grep tip tip git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git (fetch) tip git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git (push) [acme@jouet linux]$
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Andi Kleen <andi@firstfloor.org> - 2016-02-17 19:40 +0100
Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-17 20:00 +0100
Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Andi Kleen <andi@firstfloor.org> - 2016-02-17 20:20 +0100
Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-17 20:30 +0100
Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Andi Kleen <andi@firstfloor.org> - 2016-02-17 22:30 +0100
Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-17 20:00 +0100
csiph-web