[PATCH] goldfish: Return proper error code

From	Amitoj Kaur Chawla <amitoj1606@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] goldfish: Return proper error code
Date	2016-02-17 18:30 +0100
Message-ID	<r3e5l-19i-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

This change has been made with the goal that kernel functions should
return something more descriptive than -1 on failure.

Change the return value on valid_batchbuffer_addr() failure from -1 
to -EINVAL.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 9f6734c..6de6fd2 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -233,7 +233,7 @@ static int setup_access_params_addr(struct platform_device *pdev,
 		dev->aps = aps;
 		return 0;
 	} else
-		return -1;
+		return -EINVAL;
 }
 
 /* A value that will not be set by qemu emulator */
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] goldfish: Return proper error code Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-17 18:30 +0100
  Re: [PATCH] goldfish: Return proper error code One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-17 19:50 +0100
    Re: [PATCH] goldfish: Return proper error code Julia Lawall <julia.lawall@lip6.fr> - 2016-02-17 20:30 +0100
      Re: [PATCH] goldfish: Return proper error code Julia Lawall <julia.lawall@lip6.fr> - 2016-02-17 20:30 +0100

csiph-web