Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer

From	Sudeep Holla <sudeep.holla@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer
Date	2016-02-15 13:40 +0100
Message-ID	<r2qBB-Um-31@gated-at.bofh.it> (permalink)
References	<r134l-3on-3@gated-at.bofh.it> <r2qie-Lf-7@gated-at.bofh.it> <r2qBB-Um-27@gated-at.bofh.it>
Organization	ARM

Show all headers | View raw


On 15/02/16 12:31, Jassi Brar wrote:
> On Mon, Feb 15, 2016 at 5:47 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> Hi Jassi,
>>
>> On 11/02/16 17:13, Sudeep Holla wrote:
>>>
>>> Hi Lee, Jassi,
>>>
>>> Assuming mailbox-test was designed to be generic, I am trying to extend
>>> it to support single channel with separate Tx and Rx buffer. With these
>>> changes I am able to test arm_mhu driver. However I couldn't understand
>>> the intention of converting buffer to ASCII hex dump in read method.
>>> I have a local change to remove that so that it can deal with any data
>>> in any format(e.g. some protocol format) and userspace can deal with the
>>> actual interpretation of the data. Let me know your thoughts on that.
>>>
>>
>> Can you review this ? It would be good to get this in for v4.6
>>
> Seems simple enough. So once you and Lee are in sync...
>

That was quick :). Anyways IIUC Lee agrees with most of the changes.

The question I am asking is not part of this series, I didn't make the
change to remove hexdump yet, I am trying to understand the reasoning
for doing that and also explaining my requirement as why I want to
remove it.

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer Sudeep Holla <sudeep.holla@arm.com> - 2016-02-11 18:20 +0100
  [PATCH 2/4] mailbox: mailbox-test: fix the compatible string Sudeep Holla <sudeep.holla@arm.com> - 2016-02-11 18:20 +0100
    Re: [PATCH 2/4] mailbox: mailbox-test: fix the compatible string Lee Jones <lee.jones@linaro.org> - 2016-02-12 10:10 +0100
    Re: [PATCH 2/4] mailbox: mailbox-test: fix the compatible string Rob Herring <robh@kernel.org> - 2016-02-12 17:50 +0100
  [PATCH 1/4] mailbox: mailbox-test: rename driver as generic test driver Sudeep Holla <sudeep.holla@arm.com> - 2016-02-11 18:20 +0100
    Re: [PATCH 1/4] mailbox: mailbox-test: rename driver as generic test  driver Lee Jones <lee.jones@linaro.org> - 2016-02-12 10:10 +0100
  Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with  separate Tx and Rx buffer Lee Jones <lee.jones@linaro.org> - 2016-02-12 10:20 +0100
    Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with  separate Tx and Rx buffer Sudeep Holla <sudeep.holla@arm.com> - 2016-02-12 10:50 +0100
      Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with  separate Tx and Rx buffer Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 13:20 +0100
  Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with  separate Tx and Rx buffer Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 13:20 +0100
    Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with  separate Tx and Rx buffer Jassi Brar <jassisinghbrar@gmail.com> - 2016-02-15 13:40 +0100
      Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with  separate Tx and Rx buffer Sudeep Holla <sudeep.holla@arm.com> - 2016-02-15 13:40 +0100

csiph-web