Re: [PATCH] w1: w1_process() is not freezable kthread

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] w1: w1_process() is not freezable kthread
Date	2016-02-10 11:50 +0100
Message-ID	<r0Avo-12b-25@gated-at.bofh.it> (permalink)
References	(1 earlier) <qodzQ-6jT-29@gated-at.bofh.it> <qort9-6PV-17@gated-at.bofh.it> <qrt5o-7ln-27@gated-at.bofh.it> <qwzDc-2M9-25@gated-at.bofh.it> <qZMIi-Ft-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 7 Feb 2016, GregKH wrote:

> I can't find this patch anywhere in my queue, can you please resend it
> to me with the ack so I can apply it?

Greg, please find it below. Thanks.





From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] w1: w1_process() is not freezable kthread

From: Jiri Kosina <jkosina@suse.cz>

w1_process() calls try_to_freeze(), but the thread doesn't mark itself 
freezable through set_freezable(), so the try_to_freeze() call is useless.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/w1/w1.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index c9a7ff6..89a7847 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -1147,7 +1147,6 @@ int w1_process(void *data)
 			jremain = 1;
 		}
 
-		try_to_freeze();
 		__set_current_state(TASK_INTERRUPTIBLE);
 
 		/* hold list_mutex until after interruptible to prevent loosing
-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2016-02-10 11:50 +0100

csiph-web