Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331061 > unrolled thread

Re: [PATCH] w1: w1_process() is not freezable kthread

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] w1: w1_process() is not freezable kthread Jiri Kosina <jikos@kernel.org> - 2016-02-10 11:50 +0100

#1331061 — Re: [PATCH] w1: w1_process() is not freezable kthread

On Sun, 7 Feb 2016, GregKH wrote:

> I can't find this patch anywhere in my queue, can you please resend it
> to me with the ack so I can apply it?

Greg, please find it below. Thanks.





From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] w1: w1_process() is not freezable kthread

From: Jiri Kosina <jkosina@suse.cz>

w1_process() calls try_to_freeze(), but the thread doesn't mark itself 
freezable through set_freezable(), so the try_to_freeze() call is useless.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/w1/w1.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index c9a7ff6..89a7847 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -1147,7 +1147,6 @@ int w1_process(void *data)
 			jremain = 1;
 		}
 
-		try_to_freeze();
 		__set_current_state(TASK_INTERRUPTIBLE);
 
 		/* hold list_mutex until after interruptible to prevent loosing
-- 
Jiri Kosina
SUSE Labs

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web