Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329942

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip
Date 2016-02-09 07:30 +0100
Message-ID <r09Ye-eN-11@gated-at.bofh.it> (permalink)
References <r07jJ-6AS-25@gated-at.bofh.it> <r092a-81n-7@gated-at.bofh.it> <r09Ye-eN-1@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Feb 09, 2016 at 08:19:51AM +0200, Jarkko Sakkinen wrote:
> On Mon, Feb 08, 2016 at 10:26:55PM -0700, Jason Gunthorpe wrote:
> > On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote:
> > > If the initialization fails before tpm_chip_register(), put_device()
> > > will be not called, which causes release callback not to be called.
> > > This patch fixes the issue by adding put_device() to devres list of
> > > the parent device.
> > 
> > Erm, if you do this, then shouldn't the device_unregister change to
> > device_del to keep the kref balanced?
> 
> Yes, it should. Weird, I added pr_info() (temporarily) to
> tpm_dev_release() and did occur only once and no crashes whatsoever.
> 
> Anyway, you're right.

Update:

https://github.com/jsakkine/linux-tpmdd/commit/a1aa547bbd2178628df798c27abaad073acb2441

I tested that the release gets called (as a sanity check).

Ack?

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-09 04:40 +0100
  Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-09 06:30 +0100
    Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-09 07:30 +0100
      Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-09 07:30 +0100
        Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-09 18:10 +0100
  Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-11 20:40 +0100
    Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-12 04:40 +0100

csiph-web