Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329932

Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip

Show all headers | View raw

On Tue, Feb 09, 2016 at 05:30:30AM +0200, Jarkko Sakkinen wrote:
> If the initialization fails before tpm_chip_register(), put_device()
> will be not called, which causes release callback not to be called.
> This patch fixes the issue by adding put_device() to devres list of
> the parent device.

Erm, if you do this, then shouldn't the device_unregister change to
device_del to keep the kref balanced?

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-09 04:40 +0100
  Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-09 06:30 +0100
    Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-09 07:30 +0100
      Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-09 07:30 +0100
        Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-09 18:10 +0100
  Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-11 20:40 +0100
    Re: [tpmdd-devel] [PATCH] tpm: fix the cleanup of struct tpm_chip Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-12 04:40 +0100

csiph-web