Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

From	Florian Westphal <fw@strlen.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match
Date	2015-11-21 20:00 +0100
Message-ID	<qxlya-MF-1@gated-at.bofh.it> (permalink)
References	<qxj3j-7GJ-3@gated-at.bofh.it> <qxj3k-7GJ-25@gated-at.bofh.it> <qxjG3-7Xx-19@gated-at.bofh.it> <qxjPI-8h3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Tejun Heo <tj@kernel.org> wrote:
> On Sat, Nov 21, 2015 at 05:56:06PM +0100, Florian Westphal wrote:
> > > +struct xt_cgroup_info_v1 {
> > > +	__u8		has_path;
> > > +	__u8		has_classid;
> > > +	__u8		invert_path;
> > > +	__u8		invert_classid;
> > > +	char		path[PATH_MAX];
> > > +	__u32		classid;
> > > +
> > > +	/* kernel internal data */
> > > +	void		*priv __attribute__((aligned(8)));
> > > +};
> > 
> > Ahem.  Am I reading this right? This struct is > 4k in size?
> > If so -- Ugh.  Does sizeof(path) really have to be PATH_MAX?
> 
> Hmmm... yeap but would this be an acutual problem?

Since rule blob can be allocated via vmalloc i guess "no", its not
really a problem unless someone needs realy insane amount of such rules.

I don't have any better suggestion, so I guess its necessary evil.

The only other question I have is wheter PATH_MAX might be a possible
ABI breaker in future.  It would have to be guaranteed that this is the
same size forever, else you'd get strange errors on rule insertion if
the sizes of the kernel and userspace version differs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-21 17:20 +0100
  Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Florian Westphal <fw@strlen.de> - 2015-11-21 18:00 +0100
    Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-21 18:10 +0100
      Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Florian Westphal <fw@strlen.de> - 2015-11-21 20:00 +0100
        Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Jan Engelhardt <jengelh@inai.de> - 2015-11-21 21:30 +0100
        Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Borkmann <daniel@iogearbox.net> - 2015-11-23 14:50 +0100
          Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Borkmann <daniel@iogearbox.net> - 2015-11-23 15:00 +0100
          Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-23 16:50 +0100
    RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match David Laight <David.Laight@ACULAB.COM> - 2015-11-23 18:40 +0100
      RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Jan Engelhardt <jengelh@inai.de> - 2015-11-23 19:00 +0100
  Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-11-23 13:50 +0100
    Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-23 16:50 +0100

csiph-web