Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1274708

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

Show all headers | View raw

Hello,

On Sat, Nov 21, 2015 at 05:56:06PM +0100, Florian Westphal wrote:
> > +struct xt_cgroup_info_v1 {
> > +	__u8		has_path;
> > +	__u8		has_classid;
> > +	__u8		invert_path;
> > +	__u8		invert_classid;
> > +	char		path[PATH_MAX];
> > +	__u32		classid;
> > +
> > +	/* kernel internal data */
> > +	void		*priv __attribute__((aligned(8)));
> > +};
> 
> Ahem.  Am I reading this right? This struct is > 4k in size?
> If so -- Ugh.  Does sizeof(path) really have to be PATH_MAX?

Hmmm... yeap but would this be an acutual problem?  We can try to make
it shorter but idk it ultimately is a path.  Another solution would be
trying to pass inode around but that is problematic with showing and
printing rules as the only way to reverse-map inode to path is walking
the tree and the cgroup may already be gone at that point.  While >4k
struct isn't pretty, this looks like the path of least resistance.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-21 17:20 +0100
  Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Florian Westphal <fw@strlen.de> - 2015-11-21 18:00 +0100
    Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-21 18:10 +0100
      Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Florian Westphal <fw@strlen.de> - 2015-11-21 20:00 +0100
        Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Jan Engelhardt <jengelh@inai.de> - 2015-11-21 21:30 +0100
        Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Borkmann <daniel@iogearbox.net> - 2015-11-23 14:50 +0100
          Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Borkmann <daniel@iogearbox.net> - 2015-11-23 15:00 +0100
          Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-23 16:50 +0100
    RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match David Laight <David.Laight@ACULAB.COM> - 2015-11-23 18:40 +0100
      RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Jan Engelhardt <jengelh@inai.de> - 2015-11-23 19:00 +0100
  Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-11-23 13:50 +0100
    Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-23 16:50 +0100

csiph-web