Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1275293

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

Show all headers | View raw

Hi Tejun,

On 11/21/2015 05:14 PM, Tejun Heo wrote:> +static int
> cgroup_mt_check_v1(const struct xt_mtchk_param *par)
> +{
> +	struct xt_cgroup_info_v1 *info = par->matchinfo;
> +	struct cgroup *cgrp;
> +
> +	if ((info->invert_path & ~1) || (info->invert_classid & ~1))
> +		return -EINVAL;

The checks below use pr_info() in case the configuration is not valid.
Is this missing here on purpose?

I have tested it slightly and it seems to work (also on an older
kernel). I don't know if that qualifies it for a Tested-by but at least
Acked-by should do the trick:

Tested-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Daniel Wagner <daniel.wagner@bmw-carit.de>

cheers,
daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-21 17:20 +0100
  Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Florian Westphal <fw@strlen.de> - 2015-11-21 18:00 +0100
    Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-21 18:10 +0100
      Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Florian Westphal <fw@strlen.de> - 2015-11-21 20:00 +0100
        Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Jan Engelhardt <jengelh@inai.de> - 2015-11-21 21:30 +0100
        Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Borkmann <daniel@iogearbox.net> - 2015-11-23 14:50 +0100
          Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Borkmann <daniel@iogearbox.net> - 2015-11-23 15:00 +0100
          Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-23 16:50 +0100
    RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match David Laight <David.Laight@ACULAB.COM> - 2015-11-23 18:40 +0100
      RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Jan Engelhardt <jengelh@inai.de> - 2015-11-23 19:00 +0100
  Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-11-23 13:50 +0100
    Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo <tj@kernel.org> - 2015-11-23 16:50 +0100

csiph-web