Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272500

[PATCH] hid: usbhid: hid-core: fix recursive deadlock

Show all headers | View raw

The critical section protected by usbhid->lock in hid_ctrl() is too
big and in rare cases causes a recursive deadlock because of its call
to hid_input_report().

This deadlock reproduces on newer wacom tablets like 056a:033c because
the wacom driver in its irq handler ends up calling hid_hw_request()
from wacom_intuos_schedule_prox_event() in wacom_wac.c. What this means
is that it submits a report to reschedule a proximity read through a
sync ctrl call which grabs the lock in hid_ctrl(struct urb *urb)
before calling hid_input_report(). When the irq kicks in on the same
cpu, it also tries to grab the lock resulting in a recursive deadlock.

The proper fix is to shrink the critical section in hid_ctrl() to
protect only the instructions which modify usbhid, thus move the lock
after the hid_input_report() call and the deadlock dissapears.

Signed-off-by: Ioan-Adrian Ratiu <adi@adirat.com>
---
 drivers/hid/usbhid/hid-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 36712e9..5dd426f 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -477,8 +477,6 @@ static void hid_ctrl(struct urb *urb)
 	struct usbhid_device *usbhid = hid->driver_data;
 	int unplug = 0, status = urb->status;
 
-	spin_lock(&usbhid->lock);
-
 	switch (status) {
 	case 0:			/* success */
 		if (usbhid->ctrl[usbhid->ctrltail].dir == USB_DIR_IN)
@@ -498,6 +496,8 @@ static void hid_ctrl(struct urb *urb)
 		hid_warn(urb->dev, "ctrl urb status %d received\n", status);
 	}
 
+	spin_lock(&usbhid->lock);
+
 	if (unplug) {
 		usbhid->ctrltail = usbhid->ctrlhead;
 	} else {
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu <adi@adirat.com> - 2015-11-18 20:30 +0100
  Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Jiri Kosina <jikos@kernel.org> - 2015-11-18 21:40 +0100
    Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu <adi@adirat.com> - 2015-11-18 22:10 +0100
      Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Josh Cartwright <joshc@ni.com> - 2015-11-19 01:00 +0100
        Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu <adi@adirat.com> - 2015-11-19 07:50 +0100
          Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Jiri Kosina <jikos@kernel.org> - 2015-11-19 10:20 +0100
            Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu <adi@adirat.com> - 2015-11-19 17:40 +0100
              Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Jiri Kosina <jikos@kernel.org> - 2015-11-19 22:40 +0100
                Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu <adi@adirat.com> - 2015-11-20 21:10 +0100
      Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock Jiri Kosina <jikos@kernel.org> - 2015-11-19 10:00 +0100
  [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu <adi@adirat.com> - 2015-11-20 21:20 +0100
    Re: [PATCH v2] hid: usbhid: hid-core: fix recursive deadlock Ioan-Adrian Ratiu <adi@adirat.com> - 2015-11-29 11:30 +0100

csiph-web