Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272501

Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Bin Liu <binmlist@gmail.com> writes:
> On Wed, Nov 18, 2015 at 10:18 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The CPPI-4.1 driver selects TI_CPPI41, which is a dmaengine
>> driver and that may not be available when CONFIG_DMADEVICES
>> is not set:
>>
>> warning: (USB_TI_CPPI41_DMA) selects TI_CPPI41 which has unmet direct dependencies (DMADEVICES && ARCH_OMAP)
>>
>> This adds an extra dependency to avoid generating warnings in randconfig
>> builds. Ideally we'd remove the 'select' statement, but that has the
>> potential to break defconfig files.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 411dd19c682d ("usb: musb: Kconfig: Select the DMA driver if DMA mode of MUSB is enabled")
>>
>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>> index 1f2037bbeb0d..45c83baf675d 100644
>> --- a/drivers/usb/musb/Kconfig
>> +++ b/drivers/usb/musb/Kconfig
>> @@ -159,7 +159,7 @@ config USB_TI_CPPI_DMA
>>
>>  config USB_TI_CPPI41_DMA
>>         bool 'TI CPPI 4.1 (AM335x)'
>> -       depends on ARCH_OMAP
>> +       depends on ARCH_OMAP && DMADEVICES
>>         select TI_CPPI41
>
> I am not sure what the generic policy is, but instead of hiding
> USB_TI_CPPI41_DMA if DMADEVICES is disabled, I'd like to enable
> DMADEVICES if USB_TI_CPPI41_DMA is enabled, from user experience
> perspective.

that would mean "select DMADEVICES" and that's frowned upon.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Arnd Bergmann <arnd@arndb.de> - 2015-11-18 17:20 +0100
  Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Bin Liu <binmlist@gmail.com> - 2015-11-18 19:30 +0100
    Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Felipe Balbi <balbi@ti.com> - 2015-11-18 20:30 +0100
      Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Bin Liu <binmlist@gmail.com> - 2015-11-18 21:30 +0100
        Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Felipe Balbi <balbi@ti.com> - 2015-11-18 21:40 +0100
          Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Bin Liu <binmlist@gmail.com> - 2015-11-18 21:50 +0100
    Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Arnd Bergmann <arnd@arndb.de> - 2015-11-18 21:30 +0100
      Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Bin Liu <binmlist@gmail.com> - 2015-11-18 21:40 +0100
        Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Arnd Bergmann <arnd@arndb.de> - 2015-11-18 22:10 +0100
      Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support Felipe Balbi <balbi@ti.com> - 2015-11-18 21:50 +0100

csiph-web