Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1273296
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. |
| Date | 2015-11-19 18:20 +0100 |
| Message-ID | <qwB2h-3PG-1@gated-at.bofh.it> (permalink) |
| References | <qwoeK-3V4-3@gated-at.bofh.it> <qwoeL-3V4-37@gated-at.bofh.it> <qwqzV-5xV-11@gated-at.bofh.it> <qwye8-1Zi-41@gated-at.bofh.it> <qwAIX-3r7-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Nov 19, 2015 at 06:52:57PM +0200, Vladimir Zapolskiy wrote:
> On 19.11.2015 16:18, Andrew Lunn wrote:
> >>> #ifdef CONFIG_OF
> >>> +static void select_assert(void *context)
> >>> +{
> >>> + struct eeprom_93xx46_dev *edev = context;
> >>> +
> >>> + gpiod_set_value_cansleep(gpio_to_desc(edev->pdata->select_gpio), 1);
> >>
> >> I would suggest to use gpio_set_value()
> >
> > Could you explain why?
> >
> > Maybe this gpio is on an SPI GPIO expander?
>
> My point is that gpio_*() interface, gpio_set_value() or
> gpio_set_value_cansleep(), might be preferred is this particular case.
Ah, O.K, yes, avoid the gpio_to_desc() call.
Agreed.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/5] Devicetree support for misc/eeprom/eeprom_93xx46. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
[PATCH v2 1/5] misc: eeprom_93xx46: Fix 16-bit read and write accesses. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
[PATCH v2 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
Re: [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver. Rob Herring <robh@kernel.org> - 2015-11-19 16:00 +0100
Re: [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 18:40 +0100
[PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:00 +0100
Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. "Andrew F. Davis" <afd@ti.com> - 2015-11-19 15:10 +0100
Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 17:20 +0100
Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-21 06:00 +0100
Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-21 05:50 +0100
Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-21 19:40 +0100
Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-23 19:30 +0100
[PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel AT93C46D device. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
Re: [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel AT93C46D device. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:00 +0100
Re: [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel AT93C46D device. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-23 18:50 +0100
[PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:10 +0100
Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Andrew Lunn <andrew@lunn.ch> - 2015-11-19 15:20 +0100
Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 18:00 +0100
Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Andrew Lunn <andrew@lunn.ch> - 2015-11-19 18:20 +0100
Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-25 06:00 +0100
csiph-web