Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273290

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

Show all headers | View raw

On 19.11.2015 16:18, Andrew Lunn wrote:
>>>  #ifdef CONFIG_OF
>>> +static void select_assert(void *context)
>>> +{
>>> +	struct eeprom_93xx46_dev *edev = context;
>>> +
>>> +	gpiod_set_value_cansleep(gpio_to_desc(edev->pdata->select_gpio), 1);
>>
>> I would suggest to use gpio_set_value()
> 
> Could you explain why?
> 
> Maybe this gpio is on an SPI GPIO expander?

My point is that gpio_*() interface, gpio_set_value() or
gpio_set_value_cansleep(), might be preferred is this particular case.

I know it is legacy, but in this case there is no difference, if the
target have gpiolib, and the interface is broken, if the target does not
have gpiolib.

> 
>>>  static const struct of_device_id eeprom_93xx46_of_table[] = {
>>>  	{ .compatible = "eeprom-93xx46", },
>>>  	{ .compatible = "atmel,at93c46d", .data = &atmel_at93c46d_data, },
>>> @@ -385,6 +402,15 @@ static int eeprom_93xx46_probe_dt(struct spi_device *spi)
>>>  	if (of_property_read_bool(np, "read-only"))
>>>  		pd->flags |= EE_READONLY;
>>>  
>>> +	ret = of_get_named_gpio(np, "select-gpios", 0);
>>
>> gpios or gpio? I see only one requested gpio.
> 
> DT always uses the plural. Go read some bindins in Documentation/devicetree/bindings/
> 

Ok.

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] Devicetree support for misc/eeprom/eeprom_93xx46. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
  [PATCH v2 1/5] misc: eeprom_93xx46: Fix 16-bit read and write accesses. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
  [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to  eeprom_93xx46 driver. Rob Herring <robh@kernel.org> - 2015-11-19 16:00 +0100
      Re: [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to  eeprom_93xx46 driver. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 18:40 +0100
  [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:00 +0100
      Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. "Andrew F. Davis" <afd@ti.com> - 2015-11-19 15:10 +0100
        Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 17:20 +0100
        Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-21 06:00 +0100
      Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-21 05:50 +0100
        Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-21 19:40 +0100
          Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-23 19:30 +0100
  [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel AT93C46D device. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel  AT93C46D device. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:00 +0100
      Re: [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel  AT93C46D device. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-23 18:50 +0100
  [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select'  line. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:10 +0100
      Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO  'select' line. Andrew Lunn <andrew@lunn.ch> - 2015-11-19 15:20 +0100
        Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select'  line. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 18:00 +0100
          Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO  'select' line. Andrew Lunn <andrew@lunn.ch> - 2015-11-19 18:20 +0100
      Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO  'select' line. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-25 06:00 +0100

csiph-web