Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273265

Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings.

Show all headers | View raw

Hi Andrew,

On 19.11.2015 16:00, Andrew F. Davis wrote:
> On 11/18/2015 11:50 PM, Vladimir Zapolskiy wrote:
>> Hi Cory,
>>
>> On 19.11.2015 05:29, Cory Tusar wrote:
>>> This commit implements bindings in the eeprom_93xx46 driver allowing
>>> device word size and read-only attributes to be specified via
>>> devicetree.
>>>
>>> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
>>> ---

[snip]

>>> +
>>> +#else
>>> +static inline int eeprom_93xx46_probe_dt(struct spi_device *spi)
>>> +{
>>> +	return 0;
>>> +}
>>> +#endif
>>> +
>>
>> I actually don't see a point to have #ifdef CONFIG_OF here.
>>
> 
> Usually to avoid a lot of dead code and data when OF is not enabled.
> 

This is a premature optimization.


Also please see Documentation/CodingStyle, Chapter 20: Conditional
Compilation:

	Wherever possible, don't use preprocessor conditionals
	(#if, #ifdef) in .c files; doing so makes code harder to read
	and logic harder to follow.  Instead, use such conditionals in
	a header file defining functions for use in those .c files,
	providing no-op stub versions in the #else case, and then call
	those functions unconditionally from .c files.  The compiler
	will avoid generating any code for the stub calls, producing
	identical results, but the logic will remain easy to follow.

etc.

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] Devicetree support for misc/eeprom/eeprom_93xx46. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
  [PATCH v2 1/5] misc: eeprom_93xx46: Fix 16-bit read and write accesses. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
  [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to  eeprom_93xx46 driver. Rob Herring <robh@kernel.org> - 2015-11-19 16:00 +0100
      Re: [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to  eeprom_93xx46 driver. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 18:40 +0100
  [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:00 +0100
      Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. "Andrew F. Davis" <afd@ti.com> - 2015-11-19 15:10 +0100
        Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 17:20 +0100
        Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-21 06:00 +0100
      Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-21 05:50 +0100
        Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-21 19:40 +0100
          Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT  bindings. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-23 19:30 +0100
  [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel AT93C46D device. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel  AT93C46D device. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:00 +0100
      Re: [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel  AT93C46D device. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-23 18:50 +0100
  [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-19 04:40 +0100
    Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select'  line. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 07:10 +0100
      Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO  'select' line. Andrew Lunn <andrew@lunn.ch> - 2015-11-19 15:20 +0100
        Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select'  line. Vladimir Zapolskiy <vz@mleia.com> - 2015-11-19 18:00 +0100
          Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO  'select' line. Andrew Lunn <andrew@lunn.ch> - 2015-11-19 18:20 +0100
      Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO  'select' line. Cory Tusar <cory.tusar@pid1solutions.com> - 2015-11-25 06:00 +0100

csiph-web