Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270429

Re: spi: OF module autoloading is still broken

Show all headers | View raw

Hello Mark,

On 11/16/2015 02:49 PM, Mark Brown wrote:
> On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote:
>> On 11/13/2015 08:48 PM, Brian Norris wrote:
> 
>>> (I believe I avoided this in the first place for mostly-aesthetic
>>> reasons; technically this allows people to put garbage in their DT, like
>>> "garbage,spi-nor". It's unclear whether "garbage" becomes part of the
>>> mythical DT ABI [1].)
> 
>> I don't believe your examples are part of the mythical DT ABI. What I
>> understand is that an ABI is whatever is documented in the DT binding
>> docs but the only document that mentions the m25p80 is:
> 
>> Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> 
> Not really, in practice an ABI is something that people notice breaking.
> This means that if enough people ship an undocumented ABI (or it goes
> into important enough products) it's just as good as something that's
> documented, perhaps better than something that's documented and nobody
> ever uses as an ABI.
> 

I see, fair enough. Let's see what Brian say about the spi-nor case and
I'll also post my RFC patch but as a proper patch and adding the comments
you asked me later today.

It would be unfortunate if the SPI drivers would have as a requirement to
always have an SPI device ID table even for OF-only IPs but I don't think
that is that bad either.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor""  breaks module autoloading Brian Norris <computersforpeace@gmail.com> - 2015-11-12 20:00 +0100
  spi: OF module autoloading is still broken (was: Re: m25p80: Commit  "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading) Brian Norris <computersforpeace@gmail.com> - 2015-11-13 20:50 +0100
    Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Mark Brown <broonie@kernel.org> - 2015-11-13 23:20 +0100
      Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Brian Norris <computersforpeace@gmail.com> - 2015-11-14 00:00 +0100
        Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Mark Brown <broonie@kernel.org> - 2015-11-14 00:20 +0100
          Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Brian Norris <computersforpeace@gmail.com> - 2015-11-14 00:50 +0100
            Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Mark Brown <broonie@kernel.org> - 2015-11-16 15:00 +0100
              Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-16 18:30 +0100
                Re: spi: OF module autoloading is still broken Mark Brown <broonie@kernel.org> - 2015-11-16 19:00 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-16 19:10 +0100
            Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-16 18:20 +0100
              Re: spi: OF module autoloading is still broken Mark Brown <broonie@kernel.org> - 2015-11-16 19:00 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-16 19:00 +0100
              Re: spi: OF module autoloading is still broken Brian Norris <computersforpeace@gmail.com> - 2015-11-16 20:30 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-16 21:10 +0100
                Re: spi: OF module autoloading is still broken Brian Norris <computersforpeace@gmail.com> - 2015-11-16 21:50 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-16 22:40 +0100
                Re: spi: OF module autoloading is still broken Brian Norris <computersforpeace@gmail.com> - 2015-11-16 23:00 +0100
                Re: spi: OF module autoloading is still broken Mark Brown <broonie@kernel.org> - 2015-11-17 14:20 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-17 14:40 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-17 14:20 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-18 21:10 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-19 13:50 +0100
                Re: spi: OF module autoloading is still broken Mark Brown <broonie@kernel.org> - 2015-11-17 14:40 +0100
                Re: spi: OF module autoloading is still broken Javier Martinez Canillas <javier@osg.samsung.com> - 2015-11-17 14:40 +0100

csiph-web