Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1268207

Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading

Show all headers | View raw

+ others

On Sat, Oct 03, 2015 at 11:54:16PM +0200, Heiner Kallweit wrote:
> Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d
> (allow arbitrary OF matching for "jedec,spi-nor") broke autoloading
> of the m25p80 module.
> MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias
> prevents module autoloading.
> 
> Of course we could revert the removal of the "spi-nor" device alias.
> However it might be better to switch to DT-based matching for
> DT-configured devices.
> 
> Adding a call to of_device_uevent_modalias to spi_uevent in spi.c
> solved the issue for me, drawback however is that just the first
> "compatible" value is used as modalias. In case of m25p80 this means
> that "jedec,spi-nor" has to be the first "compatible" value.
> This constraint might be too strict ..
> 
> Having said that I'm not sure what could be a better way to fix
> the issue than just re-introducing the "spi-nor" device alias.

Is this [1] getting fixed in SPI any time soon? Looks like there was
some progress [2], but AFAICT it's not completed.

I'd just like to know what the way forward here should be for m25p80.
Really, "jedec,spi-nor" never autoloaded modules very reliably because
of the SPI core constaints. So I'm not sure I'd consider this a
regression, and I might be OK waiting around if it'll be fixed in a
reasonable time frame.

FWIW, I can do testing if somebody's tackling this still. Just CC me.

Regards,
Brian

[1] https://lkml.org/lkml/2014/9/11/458
[2] https://lkml.org/lkml/2015/8/20/109
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor""  breaks module autoloading Brian Norris <computersforpeace@gmail.com> - 2015-11-12 20:00 +0100
  spi: OF module autoloading is still broken (was: Re: m25p80: Commit  "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading) Brian Norris <computersforpeace@gmail.com> - 2015-11-13 20:50 +0100
    Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Mark Brown <broonie@kernel.org> - 2015-11-13 23:20 +0100
      Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Brian Norris <computersforpeace@gmail.com> - 2015-11-14 00:00 +0100
        Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Mark Brown <broonie@kernel.org> - 2015-11-14 00:20 +0100
          Re: spi: OF module autoloading is still broken (was: Re: m25p80:  Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module  autoloading) Brian Norris <computersforpeace@gmail.com> - 2015-11-14 00:50 +0100

csiph-web