Re: [PATCH] USB: USB_OTG does not depend on PM

Path	csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] USB: USB_OTG does not depend on PM
Date	Tue, 17 Nov 2015 23:30:01 +0100
Message-ID	<qvWVb-2Cu-5@gated-at.bofh.it> (permalink)
References	<qvVFM-1Tz-7@gated-at.bofh.it> <qvW8P-24z-35@gated-at.bofh.it> <qvWBR-2uT-15@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
User-Agent	Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	71
Organization	linux.* mail to news gateway
X-Original-Cc	Peter Chen <Peter.Chen@freescale.com>, <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Tue, 17 Nov 2015 16:21:06 -0600
X-Original-Message-ID	<871tbojmi5.fsf@saruman.tx.rr.com>
X-Original-References	<7521777.8ZmnT3AlIC@wuerfel> <874mgkjoh2.fsf@saruman.tx.rr.com> <5647698.81XCu85L5D@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1271704

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Arnd Bergmann <arnd@arndb.de> writes:
> On Tuesday 17 November 2015 15:38:33 Felipe Balbi wrote:
>> 
>> Arnd Bergmann <arnd@arndb.de> writes:
>> > USB_OTG initially depended on USB_SUSPEND, which was later turned into
>> > PM_RUNTIME and finally into PM. I don't know at what point the dependency
>> > became unnecessary but it appears to work fine without CONFIG_PM now.
>> >
>> > However, we get lots of warnings in randconfig kernels like:
>> >
>> > warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
>> >
>> > whenever CONFIG_PM is disabled and something else selects USB_OTG.
>> > Let's just drop the dependency to avoid the warnings.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > ---
>> > I keep seeing this one in my ARM randconfig test
>> 
>> and how did you test this ? Did you make sure you're not breaking HNP ?
>> For HNP to happen we depend on a bus_suspend and bus_suspend is only
>> available on CONFIG_PM, unless that has changed.
>> 
>> Seems like you've only compile tested this patch, is that correct ?
>
> Yes, I compile-tested only and inspected the code briefly without finding
> anything that contradicted this. It seems I missed the important part
> as you say, so we should instead add 'depends on PM' for the other
> symbols.

right, that might be better. I'll still read that code again, it has
been a few years since I looked at hnp at all.

-- 
balbi

Thread

[PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 22:10 +0100
  Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 22:40 +0100
    Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-17 23:10 +0100
      Re: [PATCH] USB: USB_OTG does not depend on PM Felipe Balbi <balbi@ti.com> - 2015-11-17 23:30 +0100
      Re: [PATCH] USB: USB_OTG does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2015-11-18 10:40 +0100

csiph-web