Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267939

Re: [PATCH] i2c: tegra: fix a possible NULL dereference

Show all headers | View raw

On 12/11/15 12:29, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Thu, Nov 12, 2015 at 08:26:03AM +0100, LABBE Corentin wrote:
>> of_match_device could return NULL, and so cause a NULL pointer
> 
> No. There is no way that of_match_device() can ever fail. The driver
> core uses the same table to match the OF device to the driver, so the
> only case where of_match_device() would return NULL is if no match was
> found, in which case the tegra_i2c_probe() function would never have
> been called in the first place.

Right and so ...

>> dereference later at line 809:
>> i2c_dev->hw = match->data;
>>
>> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
>> ---
>>  drivers/i2c/busses/i2c-tegra.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
>> index a0522fc..c803551 100644
>> --- a/drivers/i2c/busses/i2c-tegra.c
>> +++ b/drivers/i2c/busses/i2c-tegra.c
>> @@ -806,7 +806,10 @@ static int tegra_i2c_probe(struct platform_device *pdev)
>>  
>>  	if (pdev->dev.of_node) {

Can we get rid of this if-statement?

Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-12 08:30 +0100
  Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 13:30 +0100
    Re: [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <montjoie.mailing@gmail.com> - 2015-11-12 14:00 +0100
      Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 14:30 +0100
        Re: [PATCH] i2c: tegra: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 14:50 +0100
          Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 15:00 +0100
            Re: [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-12 16:00 +0100
              Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 17:20 +0100
    Re: [PATCH] i2c: tegra: fix a possible NULL dereference Jon Hunter <jonathanh@nvidia.com> - 2015-11-12 14:50 +0100
      Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 15:00 +0100

csiph-web