Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267912

Re: [PATCH] i2c: tegra: fix a possible NULL dereference

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Nov 12, 2015 at 01:54:22PM +0100, LABBE Corentin wrote:
> On Thu, Nov 12, 2015 at 01:29:23PM +0100, Thierry Reding wrote:
> > On Thu, Nov 12, 2015 at 08:26:03AM +0100, LABBE Corentin wrote:
> > > of_match_device could return NULL, and so cause a NULL pointer
> > 
> > No. There is no way that of_match_device() can ever fail. The driver
> > core uses the same table to match the OF device to the driver, so the
> > only case where of_match_device() would return NULL is if no match was
> > found, in which case the tegra_i2c_probe() function would never have
> > been called in the first place.
> > 
> > Thierry
> > 
> 
> In a parallel thread for i2c-rcar, the conclusion was different.
> https://lkml.org/lkml/2015/11/12/83

The conclusion was the same: there should be no case where this happens.
The example that Uwe gave is hypothetical and not valid DT in the first
place. So instead of chickening out I think it'd be better to just crash
to make sure people fix the DT.

On a side-note I think that platform_match() should be stricter and do
something like this instead:

	if (dev->of_node) {
		if (of_driver_match_device(dev, drv))
			return 1;

		return 0;
	}

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-12 08:30 +0100
  Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 13:30 +0100
    Re: [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <montjoie.mailing@gmail.com> - 2015-11-12 14:00 +0100
      Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 14:30 +0100
        Re: [PATCH] i2c: tegra: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 14:50 +0100
          Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 15:00 +0100
            Re: [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-12 16:00 +0100
              Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 17:20 +0100
    Re: [PATCH] i2c: tegra: fix a possible NULL dereference Jon Hunter <jonathanh@nvidia.com> - 2015-11-12 14:50 +0100
      Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 15:00 +0100

csiph-web