Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1267674

[PATCH] i2c: tegra: fix a possible NULL dereference

Show all headers | View raw

of_match_device could return NULL, and so cause a NULL pointer
dereference later at line 809:
i2c_dev->hw = match->data;

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 drivers/i2c/busses/i2c-tegra.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a0522fc..c803551 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -806,7 +806,10 @@ static int tegra_i2c_probe(struct platform_device *pdev)
 
 	if (pdev->dev.of_node) {
 		const struct of_device_id *match;
+
 		match = of_match_device(tegra_i2c_of_match, &pdev->dev);
+		if (!match)
+			return -ENODEV;
 		i2c_dev->hw = match->data;
 		i2c_dev->is_dvc = of_device_is_compatible(pdev->dev.of_node,
 						"nvidia,tegra20-i2c-dvc");
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-12 08:30 +0100
  Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 13:30 +0100
    Re: [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <montjoie.mailing@gmail.com> - 2015-11-12 14:00 +0100
      Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 14:30 +0100
        Re: [PATCH] i2c: tegra: fix a possible NULL dereference Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-11-12 14:50 +0100
          Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 15:00 +0100
            Re: [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-12 16:00 +0100
              Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 17:20 +0100
    Re: [PATCH] i2c: tegra: fix a possible NULL dereference Jon Hunter <jonathanh@nvidia.com> - 2015-11-12 14:50 +0100
      Re: [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding <thierry.reding@gmail.com> - 2015-11-12 15:00 +0100

csiph-web