Re: [PATCH] of: Print rather than WARN'ing when overlap check fails

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] of: Print rather than WARN'ing when overlap check fails
Date	2015-11-10 22:50 +0100
Message-ID	<qtoXE-27r-7@gated-at.bofh.it> (permalink)
References	<qt9lT-Gw-3@gated-at.bofh.it> <qtdIR-3jG-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2015-11-10 at 09:41 +0000, David Laight wrote:

> From: Michael Ellerman

> > Sent: 10 November 2015 05:09
> > __rmem_check_for_overlap() is called very early in boot, and on some
> > powerpc systems it's not safe to call WARN that early in boot.
> > 
> > If the overlap check fails the system will oops instead of printing a
> > warning. Furthermore because it's so early in boot the console is not up
> > and the user doesn't see the oops, they just get a dead system.
> 
> Wouldn't it be better to add the required checks to WARN()?

Yes obviously it would. But that's less simple than it sounds. I'm working on
it.

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman <mpe@ellerman.id.au> - 2015-11-10 06:10 +0100
  Re: [PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman <mpe@ellerman.id.au> - 2015-11-10 10:30 +0100
  RE: [PATCH] of: Print rather than WARN'ing when overlap check fails David Laight <David.Laight@ACULAB.COM> - 2015-11-10 10:50 +0100
    Re: [PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman <mpe@ellerman.id.au> - 2015-11-10 22:50 +0100

csiph-web