Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266351

Re: [PATCH] of: Print rather than WARN'ing when overlap check fails

Show all headers | View raw

On Tue, 2015-11-10 at 16:08 +1100, Michael Ellerman wrote:

> __rmem_check_for_overlap() is called very early in boot, and on some
> powerpc systems it's not safe to call WARN that early in boot.
> 
> If the overlap check fails the system will oops instead of printing a
> warning. Furthermore because it's so early in boot the console is not up
> and the user doesn't see the oops, they just get a dead system.
> 
> Fix it by printing an error instead of calling WARN.
> 
> Fixes: ae1add247bf8 ("of: Check for overlap in reserved memory regions")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  drivers/of/of_reserved_mem.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

I forgot to say, I assume you're OK to merge this and get it to Linus soonish?
Otherwise I can stuff it in a fix branch and ask Linus to pull that. Let me
know which you'd prefer.

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman <mpe@ellerman.id.au> - 2015-11-10 06:10 +0100
  Re: [PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman <mpe@ellerman.id.au> - 2015-11-10 10:30 +0100
  RE: [PATCH] of: Print rather than WARN'ing when overlap check fails David Laight <David.Laight@ACULAB.COM> - 2015-11-10 10:50 +0100
    Re: [PATCH] of: Print rather than WARN'ing when overlap check fails Michael Ellerman <mpe@ellerman.id.au> - 2015-11-10 22:50 +0100

csiph-web