Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

From	Elias Vanderstuyft <elias.vds@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl
Date	2015-11-10 22:50 +0100
Message-ID	<qtoXE-27r-1@gated-at.bofh.it> (permalink)
References	<q1ob0-1NF-7@gated-at.bofh.it> <qsvRw-7vV-15@gated-at.bofh.it> <qsPwS-3v4-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 9, 2015 at 8:50 AM, Benjamin Tissoires <btissoir@redhat.com> wrote:
>
> ----- Original Message -----
>> From: "Elias Vanderstuyft" <elias.vds@gmail.com>
>> To: "Benjamin Tissoires" <benjamin.tissoires@redhat.com>
>> Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "David Herrmann" <dh.herrmann@gmail.com>, "Peter Hutterer"
>> <peter.hutterer@who-t.net>, "open list:HID CORE LAYER" <linux-input@vger.kernel.org>, linux-kernel@vger.kernel.org
>> Sent: Sunday, November 8, 2015 11:55:04 AM
>> Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl
>>
>> I.e., why not:
>>
>> struct uinput_setup {
>>         char name[UINPUT_MAX_NAME_SIZE];
>>         struct input_id id;
>>         __u32 ff_effects_max;
>> };
>>
>> In case you would change this, also make sure to change the order in
>> the documentation of UI_DEV_SETUP.
>>
>
> Works for me.
> Dmitry, how do you want to handle this change? Me re-sending the whole series or you applying the change directly on your tree?

If this is too much of a hassle, please leave it as it was, I was just
being pedantic ;-)

Cheers,
Elias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and  UI_ABS_SETUP ioctl Elias Vanderstuyft <elias.vds@gmail.com> - 2015-11-08 12:00 +0100
  Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and  UI_ABS_SETUP ioctl Benjamin Tissoires <btissoir@redhat.com> - 2015-11-09 09:00 +0100
    Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and  UI_ABS_SETUP ioctl Elias Vanderstuyft <elias.vds@gmail.com> - 2015-11-10 22:50 +0100

csiph-web