Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262493

Re: [patch] vfio: make an array larger

Show all headers | View raw

Sorry, I should have said that I am on linux-next at the start.

> > -static u8 pci_cap_length[] = {
> > +static u8 pci_cap_length[PCI_CAP_ID_MAX + 1] = {
> >  	[PCI_CAP_ID_BASIC]	= PCI_STD_HEADER_SIZEOF, /* pci config header */
> >  	[PCI_CAP_ID_PM]		= PCI_PM_SIZEOF,
> >  	[PCI_CAP_ID_AGP]	= PCI_AGP_SIZEOF,
> 
> This doesn't make a whole lot of sense to me.  The last entry we define
> is:
> 
>         [PCI_CAP_ID_AF]         = PCI_CAP_AF_SIZEOF,

Yes.

> };
> 
> and PCI_CAP_ID_MAX is defined as:
> 
> #define  PCI_CAP_ID_MAX         PCI_CAP_ID_AF

No.  I am on linux-next and we appear to have added a new element
beyond PCI_CAP_ID_AF.

#define  PCI_CAP_ID_AF          0x13    /* PCI Advanced Features */
#define  PCI_CAP_ID_EA          0x14    /* PCI Enhanced Allocation */
#define  PCI_CAP_ID_MAX         PCI_CAP_ID_EA

> 
> So the array is implicitly sized to PCI_CAP_ID_MAX + 1 already, this
> doesn't make it any larger.

In linux-next it makes it larger.  But also explicitly using
PCI_CAP_ID_MAX + 1 is cleaner as well as fixing the bug in case we add
more elements later again.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] vfio: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-04 14:30 +0100
  Re: [patch] vfio: make an array larger Joe Perches <joe@perches.com> - 2015-11-04 17:50 +0100
    Re: [patch] vfio: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-04 19:30 +0100
  Re: [patch] vfio: make an array larger Alex Williamson <alex.williamson@redhat.com> - 2015-11-04 18:00 +0100
    Re: [patch] vfio: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-04 19:30 +0100
      Re: [patch] vfio: make an array larger Alex Williamson <alex.williamson@redhat.com> - 2015-11-04 19:50 +0100
        [patch v2] vfio/pci: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-09 13:30 +0100
          Re: [patch v2] vfio/pci: make an array larger Alex Williamson <alex.williamson@redhat.com> - 2015-11-10 20:10 +0100
  Re: [patch] vfio: make an array larger walter harms <wharms@bfs.de> - 2015-11-04 22:50 +0100

csiph-web