[PATCH 0/1] (Was: WARNING in task_participate_group_stop)

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH 0/1] (Was: WARNING in task_participate_group_stop)
Date	2015-11-04 19:30 +0100
Message-ID	<qraYN-411-9@gated-at.bofh.it> (permalink)
References	<qqnln-5Pq-17@gated-at.bofh.it> <qqo7N-6lo-13@gated-at.bofh.it> <qqpwS-745-21@gated-at.bofh.it> <qqqVZ-83U-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/02, Oleg Nesterov wrote:
>
> and I think this should be fixed anyway, if nothing else to make this logic more
> correct.

Yes, please see the patch.

> I'll try to recheck this all later.

I found more problems, will try to send the fixes/cleanups tomorrow...

do_signal_stop() is buggy, a multi-threaded exec can miss SIGSTOP.

task_participate_group_stop() and prepare_signal() are buggy. We
must not clear UNKILLABLE when we set STOPPED/CONTINUED.

signal_group_exit() can probably die, it was added before we had
fatal_signal_pending().

This reminds that we should finally remove signal_pending() check
in fatal_signal_pending(). And change force_sig_info() to take
->ptrace into account.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

WARNING in task_participate_group_stop Dmitry Vyukov <dvyukov@google.com> - 2015-11-02 14:30 +0100
  Re: WARNING in task_participate_group_stop Oleg Nesterov <oleg@redhat.com> - 2015-11-02 15:20 +0100
    Re: WARNING in task_participate_group_stop Dmitry Vyukov <dvyukov@google.com> - 2015-11-02 15:30 +0100
      Re: WARNING in task_participate_group_stop Oleg Nesterov <oleg@redhat.com> - 2015-11-02 15:40 +0100
    Re: WARNING in task_participate_group_stop Oleg Nesterov <oleg@redhat.com> - 2015-11-02 16:50 +0100
      Re: WARNING in task_participate_group_stop Oleg Nesterov <oleg@redhat.com> - 2015-11-02 18:20 +0100
        [PATCH 1/1] signal: kill the obsolete SIGNAL_UNKILLABLE check in  complete_signal() Oleg Nesterov <oleg@redhat.com> - 2015-11-04 19:30 +0100
          Re: [PATCH 1/1] signal: kill the obsolete SIGNAL_UNKILLABLE check  in complete_signal() Andrew Morton <akpm@linux-foundation.org> - 2015-11-05 02:30 +0100
            Re: [PATCH 1/1] signal: kill the obsolete SIGNAL_UNKILLABLE check  in complete_signal() Oleg Nesterov <oleg@redhat.com> - 2015-11-05 16:20 +0100
              Re: [PATCH 1/1] signal: kill the obsolete SIGNAL_UNKILLABLE check  in complete_signal() Oleg Nesterov <oleg@redhat.com> - 2015-11-05 18:10 +0100
        [PATCH 0/1] (Was: WARNING in task_participate_group_stop) Oleg Nesterov <oleg@redhat.com> - 2015-11-04 19:30 +0100

csiph-web