Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1266730

Re: [patch v2] vfio/pci: make an array larger

Show all headers | View raw

On Mon, 2015-11-09 at 15:24 +0300, Dan Carpenter wrote:
> Smatch complains about a possible out of bounds error:
> 
> 	drivers/vfio/pci/vfio_pci_config.c:1241 vfio_cap_init()
> 	error: buffer overflow 'pci_cap_length' 20 <= 20
> 
> The problem is that pci_cap_length[] was defined as large enough to
> hold "PCI_CAP_ID_AF + 1" elements.  The code in vfio_cap_init() assumes
> it has PCI_CAP_ID_MAX + 1 elements.  Originally, PCI_CAP_ID_AF and
> PCI_CAP_ID_MAX were the same but then we introduced PCI_CAP_ID_EA in
> f80b0ba95964 ('PCI: Add Enhanced Allocation register entries') so now
> the array is too small.
> 
> Let's fix this by making the array size PCI_CAP_ID_MAX + 1.  And let's
> make a similar change to pci_ext_cap_length[] for consistency.  Also
> both these arrays can be made const.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---

Applied to next for v4.4.  Thanks!

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] vfio: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-04 14:30 +0100
  Re: [patch] vfio: make an array larger Joe Perches <joe@perches.com> - 2015-11-04 17:50 +0100
    Re: [patch] vfio: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-04 19:30 +0100
  Re: [patch] vfio: make an array larger Alex Williamson <alex.williamson@redhat.com> - 2015-11-04 18:00 +0100
    Re: [patch] vfio: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-04 19:30 +0100
      Re: [patch] vfio: make an array larger Alex Williamson <alex.williamson@redhat.com> - 2015-11-04 19:50 +0100
        [patch v2] vfio/pci: make an array larger Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-09 13:30 +0100
          Re: [patch v2] vfio/pci: make an array larger Alex Williamson <alex.williamson@redhat.com> - 2015-11-10 20:10 +0100
  Re: [patch] vfio: make an array larger walter harms <wharms@bfs.de> - 2015-11-04 22:50 +0100

csiph-web