Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1263993

Re: GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put"

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put"
Date 2015-11-06 14:00 +0100
Message-ID <qrOMx-4BZ-11@gated-at.bofh.it> (permalink)
References (14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qrOCS-4yt-11@gated-at.bofh.it> <qrOCS-4yt-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


>> The pwm_put() function tests whether its argument is NULL and then
>> returns immediately. Thus the test around the call is not needed.
> 
> The compiler doesn't need it, but IMO it's useful documentation for humans.

How do you think about to extend the explicit documentation for
the affected parameters in the Linux programming interfaces?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put" Jani Nikula <jani.nikula@linux.intel.com> - 2015-11-06 13:50 +0100
  Re: GPU-DRM-i915: Delete an unnecessary check before the function  call "pwm_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 14:00 +0100
    Re: GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put" Jani Nikula <jani.nikula@linux.intel.com> - 2015-11-06 14:20 +0100

csiph-web