Re: [PATCH] GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put"

From	Jani Nikula <jani.nikula@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put"
Date	2015-11-06 13:50 +0100
Message-ID	<qrOCS-4yt-9@gated-at.bofh.it> (permalink)
References	(13 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qrOCS-4yt-11@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Fri, 06 Nov 2015, SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 6 Nov 2015 13:38:22 +0100
>
> The pwm_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.

The compiler doesn't need it, but IMO it's useful documentation for
humans.

BR,
Jani.


>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/gpu/drm/i915/intel_panel.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index a24df35..3d8d913 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -1729,8 +1729,7 @@ void intel_panel_destroy_backlight(struct drm_connector *connector)
>  	struct intel_panel *panel = &intel_connector->panel;
>  
>  	/* dispose of the pwm */
> -	if (panel->backlight.pwm)
> -		pwm_put(panel->backlight.pwm);
> +	pwm_put(panel->backlight.pwm);
>  
>  	panel->backlight.present = false;
>  }

-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put" Jani Nikula <jani.nikula@linux.intel.com> - 2015-11-06 13:50 +0100
  Re: GPU-DRM-i915: Delete an unnecessary check before the function  call "pwm_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 14:00 +0100
    Re: GPU-DRM-i915: Delete an unnecessary check before the function call "pwm_put" Jani Nikula <jani.nikula@linux.intel.com> - 2015-11-06 14:20 +0100

csiph-web