Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1263871
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] SRAM: Delete an unnecessary check before the function call "of_node_put" |
| Date | 2015-11-06 10:50 +0100 |
| Message-ID | <qrLOF-2KX-9@gated-at.bofh.it> (permalink) |
| References | (12 earlier) <mSsDN-4wa-59@gated-at.bofh.it> <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 6 Nov 2015 10:36:49 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/misc/sram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c index 736dae7..34287f7 100644 --- a/drivers/misc/sram.c +++ b/drivers/misc/sram.c @@ -326,9 +326,7 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res) } err_chunks: - if (child) - of_node_put(child); - + of_node_put(child); kfree(rblocks); return ret; -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] SRAM: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 10:50 +0100
csiph-web