Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263871 > unrolled thread

[PATCH] SRAM: Delete an unnecessary check before the function call "of_node_put"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] SRAM: Delete an unnecessary check before the function call  "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 10:50 +0100

#1263871 — [PATCH] SRAM: Delete an unnecessary check before the function call "of_node_put"

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 6 Nov 2015 10:36:49 +0100

The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/misc/sram.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
index 736dae7..34287f7 100644
--- a/drivers/misc/sram.c
+++ b/drivers/misc/sram.c
@@ -326,9 +326,7 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
 	}
 
  err_chunks:
-	if (child)
-		of_node_put(child);
-
+	of_node_put(child);
 	kfree(rblocks);
 
 	return ret;
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web