Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263872

Re: [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr

Show all headers | View raw

On Fri, 2015-11-06 at 13:17 +0530, Madhavan Srinivasan wrote:
> On Friday 06 November 2015 08:28 AM, Sukadev Bhattiprolu wrote:
> > Peter Zijlstra [peterz@infradead.org] wrote:
> > > On Thu, Nov 05, 2015 at 02:16:15AM +0530, Madhavan Srinivasan wrote:
> > > > Second patch updates struct arch_misc_reg for arch/powerpc with pmu registers
> > > > and adds offsetof macro for the same. It extends perf_reg_value()
> > > > to use reg idx to decide on struct to return value from.
> > > 
> > > Why; what's in those regs?
> > 
> > Those are PMU control registers/counters (in Patch 2) that are of
> > interest only in the context of a PMU interrupt and not relevant
> > to ptrace itself.
> 
> Yes. Thats right.

> > Could we add those registers to 'struct pt_regs' anyway?
> 
> I would prefer not to. Since as you mentioned, these are
> not relevant to ptrace. Currently patch 2, adds only few
> pmu registers, but would like to include more.

You can't just add them to pt_regs, it's part of the userspace ABI.

We could define a kernel internal version of pt_regs, but I don't think we want
to for this.

If we did that would bloat pt_regs for all users in the kernel, when we really
only want these regs for perf.

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH  0/3]perf/core: extend perf_reg and perf_sample_regs_intr Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-04 21:50 +0100
  [RFC PATCH  1/3] perf/core: extend perf_regs to include arch specific regs Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-04 21:50 +0100
  [RFC PATCH  3/3]perf/powerpc: Functions to update arch_misc_regs Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-04 21:50 +0100
  [RFC PATCH  2/3]perf/powerpc: update macros and add regs to arch_misc_reg struct Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-04 21:50 +0100
  Re: [RFC PATCH  0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Peter Zijlstra <peterz@infradead.org> - 2015-11-05 14:10 +0100
    Re: [RFC PATCH  0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2015-11-06 04:10 +0100
      Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-06 08:50 +0100
        Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Michael Ellerman <mpe@ellerman.id.au> - 2015-11-06 10:50 +0100
    Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-06 08:30 +0100
      Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Peter Zijlstra <peterz@infradead.org> - 2015-11-06 10:30 +0100
        Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Michael Ellerman <mpe@ellerman.id.au> - 2015-11-06 11:10 +0100
          Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Peter Zijlstra <peterz@infradead.org> - 2015-11-06 11:30 +0100
            Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-07 05:40 +0100
            Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Michael Ellerman <mpe@ellerman.id.au> - 2015-11-10 01:30 +0100
          Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-07 05:30 +0100
  Re: [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr Stephane Eranian <eranian@googlemail.com> - 2015-11-05 15:50 +0100
    Re: [RFC PATCH 0/3]perf/core: extend perf_reg and  perf_sample_regs_intr Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2015-11-06 08:40 +0100

csiph-web