Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1261309
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Date | 2015-11-03 09:50 +0100 |
| Message-ID | <qqFrZ-jV-33@gated-at.bofh.it> (permalink) |
| References | <qqmSl-5qi-15@gated-at.bofh.it> <qqmSm-5qi-29@gated-at.bofh.it> <qqxNM-3Pp-9@gated-at.bofh.it> <qqy77-3Xq-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/03/2015 01:59 AM, Krzysztof Kozlowski wrote:
> On 03.11.2015 09:30, Krzysztof Kozlowski wrote:
>> On 02.11.2015 21:56, Daniel Lezcano wrote:
>>> Let the platform's Kconfig to select the clock instead of having a reverse
>>> dependency from the driver to the platform options.
>>
>> Selecting user-visible symbols is rather discouraged so why not
>> something like this:
>>
>> - def_bool y if ARCH_EXYNOS
>> - depends on !ARM64
>> + bool "Exynos multi core timer driver"
>> + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM)
>
> Nope, that was wrong as we loose auto-select on Exynos. Instead:
> - def_bool y if ARCH_EXYNOS
> - depends on !ARM64
> + bool "Exynos multi core timer driver" if ARM
> + depends on ARCH_EXYNOS || COMPILE_TEST
> + default y if ARCH_EXYNOS
>
> This way we avoid select (which is a reverse dependency for the driver),
> have it auto-selectable and compile tested on arm.
I think you misunderstood the patch I sent.
It does two things:
1. Follow the thumb of rule of the current Kconfig format
- The timer driver is selected by the platform (exynos in this case)
- User can't select the driver in the menuconfig
- There is no dependency on the platform except for compilation test
2. Add the COMPILE_TEST
- User can select the driver for compilation testing. This is for
allyesconfig when doing compilation test coverage (exynos timer could be
compiled on other platform). As the delay code is not portable, we have
to restrict the compilation on the ARM platform, this is why there is
the dependency on ARM.
I am currently looking at splitting the delay code in order to prevent
this restriction on this driver and some others drivers.
>>> Add the COMPILE_TEST option for the compilation test coverage. Due to the
>>> non portable 'delay' code, this driver is only compilable on ARM.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>>> arch/arm/mach-exynos/Kconfig | 1 +
>>> drivers/clocksource/Kconfig | 4 ++--
>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>>> index 3a10f1a..ff10539 100644
>>> --- a/arch/arm/mach-exynos/Kconfig
>>> +++ b/arch/arm/mach-exynos/Kconfig
>>> @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS
>>> select SRAM
>>> select THERMAL
>>> select MFD_SYSCON
>>> + select CLKSRC_EXYNOS_MCT
>>> help
>>> Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)
>>>
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> index 916c36d..d829cbe 100644
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC
>>> This option enables support for the Meta per-thread timers.
>>>
>>> config CLKSRC_EXYNOS_MCT
>>> - def_bool y if ARCH_EXYNOS
>>> - depends on !ARM64
>>> + bool "Exynos multi core timer driver" if COMPILE_TEST
>>> + depends on ARM
>>> help
>>> Support for Multi Core Timer controller on Exynos SoCs.
>>>
>>>
>>
>>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/22] clocksource/drivers/pistachio: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 02/22] clocksource/drivers/mediatek: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 12/22] clocksource/drivers/tegra2: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 01:40 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 02:00 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 09:50 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Arnd Bergmann <arnd@arndb.de> - 2015-11-03 11:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 12:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 13:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 13:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option John Stultz <john.stultz@linaro.org> - 2015-11-03 17:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-03 02:00 +0100
[PATCH 13/22] clocksource/drivers/vt8500: Remove unneeded header Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 06/22] clocksource/drivers/meson6: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Linus Walleij <linus.walleij@linaro.org> - 2015-11-02 15:50 +0100
Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 16:00 +0100
[PATCH 08/22] clocksource/drivers/digicolor: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 07/22] clocksource/drivers/orion: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 15/22] clocksource/drivers/cadence_ttc: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 17/22] clocksource/drivers/lpc32xx: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 11/22] clocksource/drivers/sun5i: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 22/22] clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 16/22] clocksource/drivers/asm9260: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 18/22] clocksource/drivers/nomadik_mtu: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 04/22] clocksource/drivers/rockchip: Add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 16:40 +0100
Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 17:40 +0100
Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 22:50 +0100
[PATCH 14/22] clocksource/drivers/vt8500: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 09/22] clocksource/drivers/dw_apb: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 21/22] clocksource/drivers/samsung-pwm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
csiph-web