Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1260610 > unrolled thread
| Started by | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| First post | 2015-11-02 14:00 +0100 |
| Last post | 2015-11-02 14:10 +0100 |
| Articles | 20 on this page of 34 — 6 participants |
Back to article view | Back to linux.kernel
[PATCH 01/22] clocksource/drivers/pistachio: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 02/22] clocksource/drivers/mediatek: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 12/22] clocksource/drivers/tegra2: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 01:40 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 02:00 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 09:50 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Arnd Bergmann <arnd@arndb.de> - 2015-11-03 11:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 12:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 13:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 13:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option John Stultz <john.stultz@linaro.org> - 2015-11-03 17:10 +0100
Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-03 02:00 +0100
[PATCH 13/22] clocksource/drivers/vt8500: Remove unneeded header Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 06/22] clocksource/drivers/meson6: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
[PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Linus Walleij <linus.walleij@linaro.org> - 2015-11-02 15:50 +0100
Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 16:00 +0100
[PATCH 08/22] clocksource/drivers/digicolor: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 07/22] clocksource/drivers/orion: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 15/22] clocksource/drivers/cadence_ttc: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 17/22] clocksource/drivers/lpc32xx: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 11/22] clocksource/drivers/sun5i: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 22/22] clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 16/22] clocksource/drivers/asm9260: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 18/22] clocksource/drivers/nomadik_mtu: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 04/22] clocksource/drivers/rockchip: Add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 16:40 +0100
Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 17:40 +0100
Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 22:50 +0100
[PATCH 14/22] clocksource/drivers/vt8500: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 09/22] clocksource/drivers/dw_apb: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
[PATCH 21/22] clocksource/drivers/samsung-pwm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
Page 1 of 2 [1] 2 Next page →
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:00 +0100 |
| Subject | [PATCH 01/22] clocksource/drivers/pistachio: Add the COMPILE_TEST option |
| Message-ID | <qqmSl-5qi-15@gated-at.bofh.it> |
Increase the compilation test coverage by adding the COMPILE_TEST option. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 26f659e..a1c9312 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -112,8 +112,10 @@ config CLKSRC_LPC32XX select CLKSRC_OF config CLKSRC_PISTACHIO - bool + bool "Clocksource for Pistachio SoC" if COMPILE_TEST select CLKSRC_OF + help + Enables the clocksource for the Pistachio SoC. config CLKSRC_STM32 bool "Clocksource for STM32 SoCs" if !ARCH_STM32 -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:00 +0100 |
| Subject | [PATCH 02/22] clocksource/drivers/mediatek: Add the COMPILE_TEST option |
| Message-ID | <qqmSm-5qi-19@gated-at.bofh.it> |
| In reply to | #1260610 |
Increase the compilation test coverage by adding the COMPILE_TEST option.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index a1c9312..dc79fde 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -210,9 +210,11 @@ config SYS_SUPPORTS_SH_CMT
bool
config MTK_TIMER
+ bool "Mediatek timer driver" if COMPILE_TEST
select CLKSRC_OF
select CLKSRC_MMIO
- bool
+ help
+ Support for Mediatek timer driver.
config SYS_SUPPORTS_SH_MTU2
bool
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:00 +0100 |
| Subject | [PATCH 12/22] clocksource/drivers/tegra2: Add the COMPILE_TEST option |
| Message-ID | <qqmSm-5qi-25@gated-at.bofh.it> |
| In reply to | #1260610 |
Increase the compilation test coverage by adding the COMPILE_TEST option. Due to the non portable code for the delay timer, this option is only available for the ARM architecture. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 58dabd3..1af13c9 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -75,7 +75,10 @@ config SUN5I_HSTIMER Enables support the Sun5i timer. config TEGRA_TIMER - bool + bool "Tegra timer driver" if COMPILE_TEST + depends on ARM + help + Enables support for the Tegra driver. config VT8500_TIMER bool -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:00 +0100 |
| Subject | [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqmSm-5qi-29@gated-at.bofh.it> |
| In reply to | #1260610 |
Let the platform's Kconfig to select the clock instead of having a reverse dependency from the driver to the platform options. Add the COMPILE_TEST option for the compilation test coverage. Due to the non portable 'delay' code, this driver is only compilable on ARM. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- arch/arm/mach-exynos/Kconfig | 1 + drivers/clocksource/Kconfig | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 3a10f1a..ff10539 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS select SRAM select THERMAL select MFD_SYSCON + select CLKSRC_EXYNOS_MCT help Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 916c36d..d829cbe 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC This option enables support for the Meta per-thread timers. config CLKSRC_EXYNOS_MCT - def_bool y if ARCH_EXYNOS - depends on !ARM64 + bool "Exynos multi core timer driver" if COMPILE_TEST + depends on ARM help Support for Multi Core Timer controller on Exynos SoCs. -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-11-03 01:40 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqxNM-3Pp-9@gated-at.bofh.it> |
| In reply to | #1260615 |
On 02.11.2015 21:56, Daniel Lezcano wrote: > Let the platform's Kconfig to select the clock instead of having a reverse > dependency from the driver to the platform options. Selecting user-visible symbols is rather discouraged so why not something like this: - def_bool y if ARCH_EXYNOS - depends on !ARM64 + bool "Exynos multi core timer driver" + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) Best regards, Krzysztof > > Add the COMPILE_TEST option for the compilation test coverage. Due to the > non portable 'delay' code, this driver is only compilable on ARM. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > arch/arm/mach-exynos/Kconfig | 1 + > drivers/clocksource/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 3a10f1a..ff10539 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select SRAM > select THERMAL > select MFD_SYSCON > + select CLKSRC_EXYNOS_MCT > help > Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 916c36d..d829cbe 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC > This option enables support for the Meta per-thread timers. > > config CLKSRC_EXYNOS_MCT > - def_bool y if ARCH_EXYNOS > - depends on !ARM64 > + bool "Exynos multi core timer driver" if COMPILE_TEST > + depends on ARM > help > Support for Multi Core Timer controller on Exynos SoCs. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-11-03 02:00 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqy77-3Xq-5@gated-at.bofh.it> |
| In reply to | #1261088 |
On 03.11.2015 09:30, Krzysztof Kozlowski wrote: > On 02.11.2015 21:56, Daniel Lezcano wrote: >> Let the platform's Kconfig to select the clock instead of having a reverse >> dependency from the driver to the platform options. > > Selecting user-visible symbols is rather discouraged so why not > something like this: > > - def_bool y if ARCH_EXYNOS > - depends on !ARM64 > + bool "Exynos multi core timer driver" > + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) Nope, that was wrong as we loose auto-select on Exynos. Instead: - def_bool y if ARCH_EXYNOS - depends on !ARM64 + bool "Exynos multi core timer driver" if ARM + depends on ARCH_EXYNOS || COMPILE_TEST + default y if ARCH_EXYNOS This way we avoid select (which is a reverse dependency for the driver), have it auto-selectable and compile tested on arm. Best regards, Krzysztof > >> >> Add the COMPILE_TEST option for the compilation test coverage. Due to the >> non portable 'delay' code, this driver is only compilable on ARM. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> --- >> arch/arm/mach-exynos/Kconfig | 1 + >> drivers/clocksource/Kconfig | 4 ++-- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig >> index 3a10f1a..ff10539 100644 >> --- a/arch/arm/mach-exynos/Kconfig >> +++ b/arch/arm/mach-exynos/Kconfig >> @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS >> select SRAM >> select THERMAL >> select MFD_SYSCON >> + select CLKSRC_EXYNOS_MCT >> help >> Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 916c36d..d829cbe 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC >> This option enables support for the Meta per-thread timers. >> >> config CLKSRC_EXYNOS_MCT >> - def_bool y if ARCH_EXYNOS >> - depends on !ARM64 >> + bool "Exynos multi core timer driver" if COMPILE_TEST >> + depends on ARM >> help >> Support for Multi Core Timer controller on Exynos SoCs. >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-03 09:50 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqFrZ-jV-33@gated-at.bofh.it> |
| In reply to | #1261095 |
On 11/03/2015 01:59 AM, Krzysztof Kozlowski wrote:
> On 03.11.2015 09:30, Krzysztof Kozlowski wrote:
>> On 02.11.2015 21:56, Daniel Lezcano wrote:
>>> Let the platform's Kconfig to select the clock instead of having a reverse
>>> dependency from the driver to the platform options.
>>
>> Selecting user-visible symbols is rather discouraged so why not
>> something like this:
>>
>> - def_bool y if ARCH_EXYNOS
>> - depends on !ARM64
>> + bool "Exynos multi core timer driver"
>> + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM)
>
> Nope, that was wrong as we loose auto-select on Exynos. Instead:
> - def_bool y if ARCH_EXYNOS
> - depends on !ARM64
> + bool "Exynos multi core timer driver" if ARM
> + depends on ARCH_EXYNOS || COMPILE_TEST
> + default y if ARCH_EXYNOS
>
> This way we avoid select (which is a reverse dependency for the driver),
> have it auto-selectable and compile tested on arm.
I think you misunderstood the patch I sent.
It does two things:
1. Follow the thumb of rule of the current Kconfig format
- The timer driver is selected by the platform (exynos in this case)
- User can't select the driver in the menuconfig
- There is no dependency on the platform except for compilation test
2. Add the COMPILE_TEST
- User can select the driver for compilation testing. This is for
allyesconfig when doing compilation test coverage (exynos timer could be
compiled on other platform). As the delay code is not portable, we have
to restrict the compilation on the ARM platform, this is why there is
the dependency on ARM.
I am currently looking at splitting the delay code in order to prevent
this restriction on this driver and some others drivers.
>>> Add the COMPILE_TEST option for the compilation test coverage. Due to the
>>> non portable 'delay' code, this driver is only compilable on ARM.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>>> arch/arm/mach-exynos/Kconfig | 1 +
>>> drivers/clocksource/Kconfig | 4 ++--
>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>>> index 3a10f1a..ff10539 100644
>>> --- a/arch/arm/mach-exynos/Kconfig
>>> +++ b/arch/arm/mach-exynos/Kconfig
>>> @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS
>>> select SRAM
>>> select THERMAL
>>> select MFD_SYSCON
>>> + select CLKSRC_EXYNOS_MCT
>>> help
>>> Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)
>>>
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> index 916c36d..d829cbe 100644
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC
>>> This option enables support for the Meta per-thread timers.
>>>
>>> config CLKSRC_EXYNOS_MCT
>>> - def_bool y if ARCH_EXYNOS
>>> - depends on !ARM64
>>> + bool "Exynos multi core timer driver" if COMPILE_TEST
>>> + depends on ARM
>>> help
>>> Support for Multi Core Timer controller on Exynos SoCs.
>>>
>>>
>>
>>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-11-03 11:10 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqGHq-1jJ-39@gated-at.bofh.it> |
| In reply to | #1261309 |
On Tuesday 03 November 2015 09:40:02 Daniel Lezcano wrote: > On 11/03/2015 01:59 AM, Krzysztof Kozlowski wrote: > > On 03.11.2015 09:30, Krzysztof Kozlowski wrote: > >> On 02.11.2015 21:56, Daniel Lezcano wrote: > >>> Let the platform's Kconfig to select the clock instead of having a reverse > >>> dependency from the driver to the platform options. > >> > >> Selecting user-visible symbols is rather discouraged so why not > >> something like this: > >> > >> - def_bool y if ARCH_EXYNOS > >> - depends on !ARM64 > >> + bool "Exynos multi core timer driver" > >> + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) > > > > Nope, that was wrong as we loose auto-select on Exynos. Instead: > > - def_bool y if ARCH_EXYNOS > > - depends on !ARM64 > > + bool "Exynos multi core timer driver" if ARM > > + depends on ARCH_EXYNOS || COMPILE_TEST > > + default y if ARCH_EXYNOS > > > > This way we avoid select (which is a reverse dependency for the driver), > > have it auto-selectable and compile tested on arm. > > I think you misunderstood the patch I sent. > > It does two things: > > 1. Follow the thumb of rule of the current Kconfig format > > - The timer driver is selected by the platform (exynos in this case) > - User can't select the driver in the menuconfig > - There is no dependency on the platform except for compilation test > > 2. Add the COMPILE_TEST > > - User can select the driver for compilation testing. This is for > allyesconfig when doing compilation test coverage (exynos timer could be > compiled on other platform). As the delay code is not portable, we have > to restrict the compilation on the ARM platform, this is why there is > the dependency on ARM. > > I am currently looking at splitting the delay code in order to prevent > this restriction on this driver and some others drivers. I suspect this will come up again in the future. The problem is really that drivers/clocksource has different rules from almost everything else, by requiring the platform to 'select' the driver. The second version that Krzysztof posted is how we handle this in other driver subsystems, and I would generally prefer it to do this consistently for everything, but John Stultz has in the past argued strongly for using 'select' in all clocksource drivers. The reason is that for each platform we know in advance which driver we want, and there is never a need for the user to have to select the right one. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-03 12:10 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqHDr-1VD-11@gated-at.bofh.it> |
| In reply to | #1261360 |
On 11/03/2015 11:02 AM, Arnd Bergmann wrote: > On Tuesday 03 November 2015 09:40:02 Daniel Lezcano wrote: >> On 11/03/2015 01:59 AM, Krzysztof Kozlowski wrote: >>> On 03.11.2015 09:30, Krzysztof Kozlowski wrote: >>>> On 02.11.2015 21:56, Daniel Lezcano wrote: >>>>> Let the platform's Kconfig to select the clock instead of having a reverse >>>>> dependency from the driver to the platform options. >>>> >>>> Selecting user-visible symbols is rather discouraged so why not >>>> something like this: >>>> >>>> - def_bool y if ARCH_EXYNOS >>>> - depends on !ARM64 >>>> + bool "Exynos multi core timer driver" >>>> + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) >>> >>> Nope, that was wrong as we loose auto-select on Exynos. Instead: >>> - def_bool y if ARCH_EXYNOS >>> - depends on !ARM64 >>> + bool "Exynos multi core timer driver" if ARM >>> + depends on ARCH_EXYNOS || COMPILE_TEST >>> + default y if ARCH_EXYNOS >>> >>> This way we avoid select (which is a reverse dependency for the driver), >>> have it auto-selectable and compile tested on arm. >> >> I think you misunderstood the patch I sent. >> >> It does two things: >> >> 1. Follow the thumb of rule of the current Kconfig format >> >> - The timer driver is selected by the platform (exynos in this case) >> - User can't select the driver in the menuconfig >> - There is no dependency on the platform except for compilation test >> >> 2. Add the COMPILE_TEST >> >> - User can select the driver for compilation testing. This is for >> allyesconfig when doing compilation test coverage (exynos timer could be >> compiled on other platform). As the delay code is not portable, we have >> to restrict the compilation on the ARM platform, this is why there is >> the dependency on ARM. >> >> I am currently looking at splitting the delay code in order to prevent >> this restriction on this driver and some others drivers. > > I suspect this will come up again in the future. The problem is > really that drivers/clocksource has different rules from almost > everything else, by requiring the platform to 'select' the driver. > > The second version that Krzysztof posted is how we handle this in > other driver subsystems, and I would generally prefer it to do this > consistently for everything, but John Stultz has in the past argued > strongly for using 'select' in all clocksource drivers. The reason > is that for each platform we know in advance which driver we want, > and there is never a need for the user to have to select the right > one. Yes, and I second John in this. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-11-03 13:10 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqIzw-2w3-13@gated-at.bofh.it> |
| In reply to | #1261360 |
W dniu 03.11.2015 o 19:02, Arnd Bergmann pisze: > On Tuesday 03 November 2015 09:40:02 Daniel Lezcano wrote: >> On 11/03/2015 01:59 AM, Krzysztof Kozlowski wrote: >>> On 03.11.2015 09:30, Krzysztof Kozlowski wrote: >>>> On 02.11.2015 21:56, Daniel Lezcano wrote: >>>>> Let the platform's Kconfig to select the clock instead of having a reverse >>>>> dependency from the driver to the platform options. >>>> >>>> Selecting user-visible symbols is rather discouraged so why not >>>> something like this: >>>> >>>> - def_bool y if ARCH_EXYNOS >>>> - depends on !ARM64 >>>> + bool "Exynos multi core timer driver" >>>> + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) >>> >>> Nope, that was wrong as we loose auto-select on Exynos. Instead: >>> - def_bool y if ARCH_EXYNOS >>> - depends on !ARM64 >>> + bool "Exynos multi core timer driver" if ARM >>> + depends on ARCH_EXYNOS || COMPILE_TEST >>> + default y if ARCH_EXYNOS >>> >>> This way we avoid select (which is a reverse dependency for the driver), >>> have it auto-selectable and compile tested on arm. >> >> I think you misunderstood the patch I sent. >> >> It does two things: >> >> 1. Follow the thumb of rule of the current Kconfig format >> >> - The timer driver is selected by the platform (exynos in this case) >> - User can't select the driver in the menuconfig >> - There is no dependency on the platform except for compilation test >> >> 2. Add the COMPILE_TEST >> >> - User can select the driver for compilation testing. This is for >> allyesconfig when doing compilation test coverage (exynos timer could be >> compiled on other platform). As the delay code is not portable, we have >> to restrict the compilation on the ARM platform, this is why there is >> the dependency on ARM. >> >> I am currently looking at splitting the delay code in order to prevent >> this restriction on this driver and some others drivers. > > I suspect this will come up again in the future. The problem is > really that drivers/clocksource has different rules from almost > everything else, by requiring the platform to 'select' the driver. > > The second version that Krzysztof posted is how we handle this in > other driver subsystems, and I would generally prefer it to do this > consistently for everything, but John Stultz has in the past argued > strongly for using 'select' in all clocksource drivers. The reason > is that for each platform we know in advance which driver we want, > and there is never a need for the user to have to select the right > one. Arnd, Daniel, Sure, makes sense to me, thanks for explanation. Actually this makes me thinking that drivers/soc/* should probably follow the same convention... but not all of them do that. Anyway the patch worked fine and with explanation I can only confirm: Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-03 13:10 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqIzw-2w3-23@gated-at.bofh.it> |
| In reply to | #1261442 |
On 11/03/2015 01:01 PM, Krzysztof Kozlowski wrote: > Anyway the patch worked fine and with explanation I can only confirm: Great ! Thanks Krzysztof for testing. -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | John Stultz <john.stultz@linaro.org> |
|---|---|
| Date | 2015-11-03 17:10 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqMjN-53W-27@gated-at.bofh.it> |
| In reply to | #1261360 |
On Tue, Nov 3, 2015 at 2:02 AM, Arnd Bergmann <arnd@arndb.de> wrote: > I suspect this will come up again in the future. The problem is > really that drivers/clocksource has different rules from almost > everything else, by requiring the platform to 'select' the driver. > > The second version that Krzysztof posted is how we handle this in > other driver subsystems, and I would generally prefer it to do this > consistently for everything, but John Stultz has in the past argued > strongly for using 'select' in all clocksource drivers. The reason > is that for each platform we know in advance which driver we want, > and there is never a need for the user to have to select the right > one. And just to clarify, I don't necessarily think "select" is the right method, as creating an option that defaults to Y if the right architecture/platform support is present is fine too. I just don't want users to have to search deeply through menuconfig to find a clocksource driver checkbox when they have already selected a platform and provided enough information for us to know which clocksource driver is needed. So my argument its really all about avoiding user-prompts in kconfig for clocksources. It is conceptually easier to do this w/ select, but you can also do it via default y and proper dependencies. thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2015-11-03 02:00 +0100 |
| Subject | Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqy77-3Xq-11@gated-at.bofh.it> |
| In reply to | #1260615 |
Hi, On 2015년 11월 02일 21:56, Daniel Lezcano wrote: > Let the platform's Kconfig to select the clock instead of having a reverse > dependency from the driver to the platform options. > > Add the COMPILE_TEST option for the compilation test coverage. Due to the > non portable 'delay' code, this driver is only compilable on ARM. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > arch/arm/mach-exynos/Kconfig | 1 + > drivers/clocksource/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 3a10f1a..ff10539 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select SRAM > select THERMAL > select MFD_SYSCON > + select CLKSRC_EXYNOS_MCT > help > Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 916c36d..d829cbe 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC > This option enables support for the Meta per-thread timers. > > config CLKSRC_EXYNOS_MCT > - def_bool y if ARCH_EXYNOS > - depends on !ARM64 > + bool "Exynos multi core timer driver" if COMPILE_TEST > + depends on ARM > help > Support for Multi Core Timer controller on Exynos SoCs. > > Looks good to me. As you commented, delay_timer is only used on ARM 32bit. I'm glad to use the 'depends on ARM' instead of reverse dependency. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:00 +0100 |
| Subject | [PATCH 13/22] clocksource/drivers/vt8500: Remove unneeded header |
| Message-ID | <qqmSm-5qi-33@gated-at.bofh.it> |
| In reply to | #1260610 |
Remove the <asm/time.h> header inclusion which is pointless. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/vt8500_timer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/vt8500_timer.c b/drivers/clocksource/vt8500_timer.c index a92e94b..de49805 100644 --- a/drivers/clocksource/vt8500_timer.c +++ b/drivers/clocksource/vt8500_timer.c @@ -30,7 +30,6 @@ #include <linux/clocksource.h> #include <linux/clockchips.h> #include <linux/delay.h> -#include <asm/mach/time.h> #include <linux/of.h> #include <linux/of_address.h> -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:00 +0100 |
| Subject | [PATCH 06/22] clocksource/drivers/meson6: Add the COMPILE_TEST option |
| Message-ID | <qqmSm-5qi-37@gated-at.bofh.it> |
| In reply to | #1260610 |
Increase the compilation test coverage by adding the COMPILE_TEST option. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 0b5bdb4..2c76c2d 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -44,8 +44,10 @@ config ARMADA_370_XP_TIMER Enables the support for the Armada 370 and XP timer driver. config MESON6_TIMER - bool + bool "Meson6 timer driver" if COMPILE_TEST select CLKSRC_MMIO + help + Enables the support for the Meson6 timer driver. config ORION_TIMER select CLKSRC_OF -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:00 +0100 |
| Subject | [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqmSm-5qi-41@gated-at.bofh.it> |
| In reply to | #1260610 |
Let the platform's Kconfig to select the clock instead of having a reverse dependency from the driver to the platform options. Add the COMPILE_TEST option for the compilation test coverage. This change is debatable as the option itself in the Kconfig allows to select the driver for the platform or not. This change will make the prcmu timer always selected. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- arch/arm/mach-ux500/Kconfig | 1 + drivers/clocksource/Kconfig | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig index c9ac19b..5eacdd6 100644 --- a/arch/arm/mach-ux500/Kconfig +++ b/arch/arm/mach-ux500/Kconfig @@ -32,6 +32,7 @@ config UX500_SOC_DB8500 select PINCTRL_AB8540 select REGULATOR select REGULATOR_DB8500_PRCMU + select CLKSRC_DBX500_PRCMU select PM_GENERIC_DOMAINS if PM config MACH_MOP500 diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 17674b4..916c36d 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -114,9 +114,7 @@ config CLKSRC_NOMADIK_MTU_SCHED_CLOCK Use the Multi Timer Unit as the sched_clock. config CLKSRC_DBX500_PRCMU - bool "Clocksource PRCMU Timer" - depends on UX500_SOC_DB8500 - default y + bool "Clocksource PRCMU Timer" if COMPILE_TEST help Use the always on PRCMU Timer as clocksource -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2015-11-02 15:50 +0100 |
| Subject | Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqoAO-6vo-17@gated-at.bofh.it> |
| In reply to | #1260619 |
On Mon, Nov 2, 2015 at 1:56 PM, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > Let the platform's Kconfig to select the clock instead of having a reverse > dependency from the driver to the platform options. > > Add the COMPILE_TEST option for the compilation test coverage. > > This change is debatable as the option itself in the Kconfig allows to > select the driver for the platform or not. This change will make the prcmu > timer always selected. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Please merge this into the clksrc tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 16:00 +0100 |
| Subject | Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option |
| Message-ID | <qqoKu-6yI-21@gated-at.bofh.it> |
| In reply to | #1260691 |
On 11/02/2015 03:40 PM, Linus Walleij wrote: > On Mon, Nov 2, 2015 at 1:56 PM, Daniel Lezcano > <daniel.lezcano@linaro.org> wrote: > >> Let the platform's Kconfig to select the clock instead of having a reverse >> dependency from the driver to the platform options. >> >> Add the COMPILE_TEST option for the compilation test coverage. >> >> This change is debatable as the option itself in the Kconfig allows to >> select the driver for the platform or not. This change will make the prcmu >> timer always selected. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Please merge this into the clksrc tree. Thanks for the review. -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:10 +0100 |
| Subject | [PATCH 08/22] clocksource/drivers/digicolor: Add the COMPILE_TEST option |
| Message-ID | <qqn21-5Jb-7@gated-at.bofh.it> |
| In reply to | #1260610 |
Increase the compilation test coverage by adding the COMPILE_TEST option. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 8a80221..5b0f63a 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -19,7 +19,9 @@ config CLKSRC_MMIO bool config DIGICOLOR_TIMER - bool + bool "Digicolor timer driver" if COMPILE_TEST + help + Enables the support for the digicolor timer driver. config DW_APB_TIMER bool -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-11-02 14:10 +0100 |
| Subject | [PATCH 07/22] clocksource/drivers/orion: Add the COMPILE_TEST option |
| Message-ID | <qqn22-5Jb-13@gated-at.bofh.it> |
| In reply to | #1260610 |
Increase the compilation test coverage by adding the COMPILE_TEST option. The driver is using the atomic_io API which is not portable, so the compilation is restricted to ARM only. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- drivers/clocksource/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index 2c76c2d..8a80221 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -50,9 +50,12 @@ config MESON6_TIMER Enables the support for the Meson6 timer driver. config ORION_TIMER + bool "Orion timer driver" if COMPILE_TEST + depends on ARM select CLKSRC_OF select CLKSRC_MMIO - bool + help + Enables the support for the Orion timer driver config SUN4I_TIMER select CLKSRC_MMIO -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
Page 1 of 2 [1] 2 Next page →
Back to top | Article view | linux.kernel
csiph-web