Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260784

Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible

Show all headers | View raw

On 11/02/2015 04:33 PM, Arnd Bergmann wrote:
> On Monday 02 November 2015 13:56:31 Daniel Lezcano wrote:
>>   static inline void rk_timer_disable(struct clock_event_device *ce)
>>   {
>>          writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG);
>> -       dsb();
>> +       dsb(sy);
>>   }
>>
>>   static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags)
>>   {
>>          writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags,
>>                         rk_base(ce) + TIMER_CONTROL_REG);
>> -       dsb();
>> +       dsb(sy);
>>   }
>>
>>
>
> This will fail the compile test, because dsb() is not available on non-ARM
> architectures. Would it be enough to just use the normal writel() accessor
> here?

That's a good question and I believe we can remove it but I have to 
setup a rockchip board before doing the changes in order to test.

I the meantime added the COMPILE_TEST option but restricted it to ARM 
and ARM64.



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/22] clocksource/drivers/pistachio: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
  [PATCH 02/22] clocksource/drivers/mediatek: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
  [PATCH 12/22] clocksource/drivers/tegra2: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
  [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
    Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 01:40 +0100
      Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 02:00 +0100
        Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 09:50 +0100
          Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option Arnd Bergmann <arnd@arndb.de> - 2015-11-03 11:10 +0100
            Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 12:10 +0100
            Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-03 13:10 +0100
              Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-03 13:10 +0100
            Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option John Stultz <john.stultz@linaro.org> - 2015-11-03 17:10 +0100
    Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add  COMPILE_TEST option Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-03 02:00 +0100
  [PATCH 13/22] clocksource/drivers/vt8500: Remove unneeded header Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
  [PATCH 06/22] clocksource/drivers/meson6: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
  [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:00 +0100
    Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add  COMPILE_TEST option Linus Walleij <linus.walleij@linaro.org> - 2015-11-02 15:50 +0100
      Re: [PATCH 19/22] clocksource/drivers/prcmu: Fix Kconfig and add  COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 16:00 +0100
  [PATCH 08/22] clocksource/drivers/digicolor: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 07/22] clocksource/drivers/orion: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 15/22] clocksource/drivers/cadence_ttc: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 17/22] clocksource/drivers/lpc32xx: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 11/22] clocksource/drivers/sun5i: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 22/22] clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 16/22] clocksource/drivers/asm9260: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 18/22] clocksource/drivers/nomadik_mtu: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 04/22] clocksource/drivers/rockchip: Add COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
    Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 16:40 +0100
      Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more  compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 17:40 +0100
        Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Arnd Bergmann <arnd@arndb.de> - 2015-11-02 22:50 +0100
  [PATCH 14/22] clocksource/drivers/vt8500: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 09/22] clocksource/drivers/dw_apb: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100
  [PATCH 21/22] clocksource/drivers/samsung-pwm: Add the COMPILE_TEST option Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-02 14:10 +0100

csiph-web