Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261261

Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions

Show all headers | View raw

On Mon, Nov 2, 2015 at 10:30 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Mon, Nov 02, 2015 at 11:18:37PM -0500, Sinan Kaya wrote:
>>
>>
>> On 11/2/2015 11:15 PM, Vinod Koul wrote:
>> >On Mon, Nov 02, 2015 at 01:07:38AM -0500, Sinan Kaya wrote:
>> >>This patch adds supporting utility functions
>> >>for selftest. The intention is to share the self
>> >>test code between different drivers.
>> >>
>> >>Supported test cases include:
>> >>1. dma_map_single
>> >>2. streaming DMA
>> >>3. coherent DMA
>> >>4. scatter-gather DMA
>> >
>> >This seems quite similar to dmatest, any reason why you cannot use/enhance
>> >that?
>> >
>> Dmatest is a standalone kernel module intended for stress testing
>> DMA engines from userspace with N number of threads and M size
>> combinations etc.
>>
>> This one; on the other hand, is selftest to verify hardware is
>> working as expected during power up.
>>
>> Almost all DMA engine drivers come with some sort of selftest code
>> called from probe. I followed the same design pattern.
>
> which ones ?
>
>>
>> I think the goal is to remove the duplicate self test code in all
>> drivers over time.
>
> and what prevents us from having common selftest plus dmatest code. Most of
> the code here to do selftest is _same_ dmaengine routine code used in
> dmatest
>
> We can have common code which is used for dmatest as well as selftest. I do
> not want to see same code duplicated..

Originally ioatdma and iop-adma had local self tests before Haavard
created dmatest.  I agree having the drivers also do a test each boot
is redundant, but then again dmatest is not automatic and I saw the
local self test catch an interrupt setup regression.

Maybe you could arrange for drivers to do a quick autorun through
dmatest on load if dmatest is enabled, but otherwise load without
testing?  Just my 2 cents from a dmaengine spectator.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-02 07:10 +0100
  Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 05:20 +0100
    Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 07:40 +0100
      Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Dan Williams <dan.j.williams@intel.com> - 2015-11-03 08:50 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-03 09:30 +0100
          Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 17:10 +0100
            Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 03:50 +0100
              Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-05 13:10 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 17:20 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-07 07:30 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-08 15:00 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support  functions okaya@codeaurora.org - 2015-11-13 21:30 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 17:00 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 17:10 +0100
    Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-03 15:40 +0100
      Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 17:10 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 17:30 +0100
          Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-03 17:50 +0100
            Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 18:00 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-03 17:50 +0100
  Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 05:20 +0100

csiph-web