Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1261666

Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions

From Vinod Koul <vinod.koul@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions
Date 2015-11-03 17:10 +0100
Message-ID <qqMjM-53W-7@gated-at.bofh.it> (permalink)
References (1 earlier) <qqgtz-1NE-1@gated-at.bofh.it> <qqBeG-69S-11@gated-at.bofh.it> <qqBeG-69S-9@gated-at.bofh.it> <qqDq9-7tu-9@gated-at.bofh.it> <qqEvU-8a2-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Nov 02, 2015 at 11:44:23PM -0800, Dan Williams wrote:
> Originally ioatdma and iop-adma had local self tests before Haavard
> created dmatest.  I agree having the drivers also do a test each boot
> is redundant, but then again dmatest is not automatic and I saw the
> local self test catch an interrupt setup regression.

Well the question here is not about why selftest but rather code duplication
and using same routines for both selftest as well as dmatest
> 
> Maybe you could arrange for drivers to do a quick autorun through
> dmatest on load if dmatest is enabled, but otherwise load without
> testing?

That would be a good thing to do, but then most distro just enable all
config options, so this should be protected for "test" builds

>  Just my 2 cents from a dmaengine spectator.

Thats an understatement :)

> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-02 07:10 +0100
  Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 05:20 +0100
    Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 07:40 +0100
      Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Dan Williams <dan.j.williams@intel.com> - 2015-11-03 08:50 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-03 09:30 +0100
          Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 17:10 +0100
            Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 03:50 +0100
              Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-05 13:10 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 17:20 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-07 07:30 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-08 15:00 +0100
                Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support  functions okaya@codeaurora.org - 2015-11-13 21:30 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 17:00 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 17:10 +0100
    Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-03 15:40 +0100
      Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 17:10 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 17:30 +0100
          Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-03 17:50 +0100
            Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Sinan Kaya <okaya@codeaurora.org> - 2015-11-03 18:00 +0100
        Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Timur Tabi <timur@codeaurora.org> - 2015-11-03 17:50 +0100
  Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions Vinod Koul <vinod.koul@intel.com> - 2015-11-03 05:20 +0100

csiph-web