Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261262

Re: [PATCH] perf sched latency: Fix removed thread issue

Show all headers | View raw

On Mon, Nov 02, 2015 at 07:53:53PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Nov 02, 2015 at 12:10:25PM +0100, Jiri Olsa escreveu:
> > If machine's thread gets excited (EXIT event is received),
> > we set thread->dead = true and it is later on removed from
> > machine's tree if the pid is reused on new thread.
> 
> > The latency subcommand holds tree of working atoms sorted
> > by thread's pid/tid. If there's new thread with same pid
> 
> Humm, wher is the latency subcommand handling the EXIT event?
> 
> I see:
> 
>    perf_sched__lat
>      perf_sched__read_events
>        session = perf_session__new(&file, false, &sched->tool);
>        perf_session__process_events(session)
> 
> And sched->tool->exit() is not set, which will make
> perf_session__process_events(), when calling perf_tool__fill_defaults()
> set it to process_event_stub() which will do nothing for
> PERF_RECORD_EXIT events, no?

yep, latency command does not handle EXIT event, but the
thread is removed via FORK event.. the first changelog
paragraph might be a little misleading sorry ;-)

could you please change it to:

---
If machine's thread gets excited (EXIT event is received),
we set thread->dead = true and it is later on removed from
machine's tree if the pid is reused on new thread.

We dont handle EXIT command in 'perf sched latency',
however the old thread is removed anyway when FORK
event is received for new thrad with same pid/tid.
---

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf sched latency: Fix removed thread issue Jiri Olsa <jolsa@kernel.org> - 2015-11-02 12:20 +0100
  Re: [PATCH] perf sched latency: Fix removed thread issue Namhyung Kim <namhyung@kernel.org> - 2015-11-02 23:30 +0100
    Re: [PATCH] perf sched latency: Fix removed thread issue Jiri Olsa <jolsa@redhat.com> - 2015-11-03 09:20 +0100
  Re: [PATCH] perf sched latency: Fix removed thread issue Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-03 00:00 +0100
    Re: [PATCH] perf sched latency: Fix removed thread issue Jiri Olsa <jolsa@redhat.com> - 2015-11-03 08:50 +0100
      Re: [PATCH] perf sched latency: Fix removed thread issue Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-03 19:40 +0100
        Re: [PATCH] perf sched latency: Fix removed thread issue Jiri Olsa <jolsa@redhat.com> - 2015-11-04 08:40 +0100
  [tip:perf/urgent] perf sched latency: Fix thread pid reuse issue tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-11-08 08:40 +0100

csiph-web