Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1259032

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004
Date 2015-10-29 22:50 +0100
Message-ID <qp3f4-5BD-17@gated-at.bofh.it> (permalink)
References <qoJ6G-1gW-11@gated-at.bofh.it> <qoPON-5DQ-13@gated-at.bofh.it> <qoWng-1hg-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thursday 29 October 2015 09:22:37 Michael Welling wrote:
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/built-in.o: In function `tsc2005_cmd':
> > >> tsc200x-core.c:(.text+0x2ae07f): undefined reference to `i2c_smbus_write_byte'
> 
> Argh!
> 
> How do I fix this one?
> 

Move all the I2C specific code into the tsc2004.c file and remove the
#ifdef. The problem is that tsc200x-core.c is used as built-in when
TOUCHSCREEN_TSC2005=y and I2C=m, so it can't call functions that are
defined in i2c-core.c.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 kbuild test robot <lkp@intel.com> - 2015-10-29 08:30 +0100
  Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling <mwelling@ieee.org> - 2015-10-29 15:30 +0100
    Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Arnd Bergmann <arnd@arndb.de> - 2015-10-29 22:50 +0100
      Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling <mwelling@ieee.org> - 2015-10-29 23:00 +0100
        Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-29 23:30 +0100
          Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Mark Brown <broonie@kernel.org> - 2015-10-30 01:40 +0100
            Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling <mwelling@ieee.org> - 2015-10-30 02:10 +0100
              Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Arnd Bergmann <arnd@arndb.de> - 2015-10-30 11:50 +0100

csiph-web