Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1259043

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

Show all headers | View raw

On Thu, Oct 29, 2015 at 04:53:53PM -0500, Michael Welling wrote:
> On Thu, Oct 29, 2015 at 10:46:20PM +0100, Arnd Bergmann wrote:
> > On Thursday 29 October 2015 09:22:37 Michael Welling wrote:
> > > > 
> > > > All errors (new ones prefixed by >>):
> > > > 
> > > >    drivers/built-in.o: In function `tsc2005_cmd':
> > > > >> tsc200x-core.c:(.text+0x2ae07f): undefined reference to `i2c_smbus_write_byte'
> > > 
> > > Argh!
> > > 
> > > How do I fix this one?
> > > 
> > 
> > Move all the I2C specific code into the tsc2004.c file and remove the
> > #ifdef. The problem is that tsc200x-core.c is used as built-in when
> > TOUCHSCREEN_TSC2005=y and I2C=m, so it can't call functions that are
> > defined in i2c-core.c.
> 
> How would I call the function from the core then?

You can pass a cmd function from the transport module into core module
and store and use it.

However, you have regmap in the driver core already. Mark, is it
possible to have regmap API also allow doing raw underlying protocol
transfer so that consumers could issue command requests without needing
to know if they need to do it over i2c or spi or whatever. Or we need a
notion of command registers in regmap...

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 kbuild test robot <lkp@intel.com> - 2015-10-29 08:30 +0100
  Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling <mwelling@ieee.org> - 2015-10-29 15:30 +0100
    Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Arnd Bergmann <arnd@arndb.de> - 2015-10-29 22:50 +0100
      Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling <mwelling@ieee.org> - 2015-10-29 23:00 +0100
        Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-29 23:30 +0100
          Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Mark Brown <broonie@kernel.org> - 2015-10-30 01:40 +0100
            Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Michael Welling <mwelling@ieee.org> - 2015-10-30 02:10 +0100
              Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004 Arnd Bergmann <arnd@arndb.de> - 2015-10-30 11:50 +0100

csiph-web