Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

From	James Hogan <james.hogan@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes
Date	2015-10-16 12:40 +0200
Message-ID	<qkaAy-3B7-13@gated-at.bofh.it> (permalink)
References	<qgDhL-2Zi-5@gated-at.bofh.it> <qgDhL-2Zi-3@gated-at.bofh.it> <qjMoy-1d8-21@gated-at.bofh.it> <qkahc-3cA-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Alex,

On Fri, Oct 16, 2015 at 11:11:29AM +0100, Alex Smith wrote:
> Hi James,
> 
> On 15 October 2015 at 09:47, James Hogan <james.hogan@imgtec.com> wrote:
> >> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> >> index 9fcb9e7..453f1d3 100644
> >> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> >> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> >> @@ -42,3 +42,57 @@
> >>  &uart4 {
> >>       status = "okay";
> >>  };
> >> +
> >> +&nemc {
> >> +     status = "okay";
> >> +
> >> +     nand: nand@1 {
> >> +             compatible = "ingenic,jz4780-nand";
> >
> > Isn't the NAND a micron part? This doesn't seem right. Is the device
> > driver and binding already accepted upstream with that compatible
> > string?
> 
> This is the compatible string for the JZ4780 NAND driver, this patch
> is part of the series adding that. Detection of the NAND part is
> handled by the MTD subsystem.

Right (didn't spot that it was part of a series).

The node appears to describe the NAND interface itself, i.e. a part of
the SoC, so should be in the SoC dtsi file, with overrides in the board
file if necessary for it to work with a particular NAND part
(potentially utilising status="disabled"). Would you agree?

Cheers
James

Thread

[PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes Harvey Hunt <harvey.hunt@imgtec.com> - 2015-10-06 18:30 +0200
  Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND  device tree nodes Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-10-08 23:30 +0200
    RE: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND  device tree nodes Harvey Hunt <Harvey.Hunt@imgtec.com> - 2015-10-14 11:20 +0200
  Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND  device tree nodes James Hogan <james.hogan@imgtec.com> - 2015-10-15 10:50 +0200
    Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND  device tree nodes Alex Smith <alex@alex-smith.me.uk> - 2015-10-16 12:20 +0200
      Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND  device tree nodes James Hogan <james.hogan@imgtec.com> - 2015-10-16 12:40 +0200
        Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND  device tree nodes Paul Burton <paul.burton@imgtec.com> - 2015-10-16 12:50 +0200

csiph-web