Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1248566

Re: futex timeout not working? (bisected)

Show all headers | View raw

On Fri, 16 Oct 2015, Heiko Carstens wrote:
> On Fri, Oct 16, 2015 at 12:21:51PM +0200, Thomas Gleixner wrote:
> > Heiko,
> > 
> > On Thu, 15 Oct 2015, Heiko Carstens wrote:
> > >   /* We wait for half a second.  */
> > >   ts.tv_nsec += 500000000;
> > >   if (ts.tv_nsec >= 1000000000)
> > >     {
> > >       ++ts.tv_sec;
> > >       ts.tv_nsec -= 1000000000;
> > >     }
> > > 
> > >   ret = syscall (__NR_futex, &futex_word, op, expected, ts, NULL, FUTEX_BITSET_MATCH_ANY);
> > 
> > If you actually hand in a pointer to 'ts' then the program works as
> > expected even with the commit in question applied.
> 
> Yes, sorry about that! I was just about to write that this should have
> been &ts on x86. Since x86 seems to pass also structures >8 bytes by
> value.
> 
> However on s390 it is passed by reference. So even it I change ts to &ts,
> it will hang as I described.
> 
> So you are saying this works on x86 and it must be some s390 specific bug?

Looks like. I have no idea why that would break on s390. Did you try
to revert the commit on top of tree?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

futex timeout not working? (bisected) Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-10-15 12:50 +0200
  Re: futex timeout not working? (bisected) Thomas Gleixner <tglx@linutronix.de> - 2015-10-16 12:30 +0200
    Re: futex timeout not working? (bisected) Thomas Gleixner <tglx@linutronix.de> - 2015-10-16 12:40 +0200
      Re: futex timeout not working? (bisected) Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-10-16 13:00 +0200
        Re: futex timeout not working? (bisected) Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-10-16 14:00 +0200
          Re: futex timeout not working? (bisected) Thomas Gleixner <tglx@linutronix.de> - 2015-10-16 14:30 +0200
            Re: futex timeout not working? (bisected) Thomas Gleixner <tglx@linutronix.de> - 2015-10-16 14:50 +0200
              Re: futex timeout not working? (bisected) Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-10-16 15:50 +0200
    Re: futex timeout not working? (bisected) Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-10-16 12:40 +0200
      Re: futex timeout not working? (bisected) Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-10-16 12:40 +0200
      Re: futex timeout not working? (bisected) Thomas Gleixner <tglx@linutronix.de> - 2015-10-16 12:40 +0200

csiph-web