Re: [PATCH] mutex: make mutex_lock_nested an inline function

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mutex: make mutex_lock_nested an inline function
Date	2015-10-14 10:30 +0200
Message-ID	<qjpBE-1hT-13@gated-at.bofh.it> (permalink)
References	<qjewy-LU-17@gated-at.bofh.it> <qjewy-LU-15@gated-at.bofh.it> <qjfCj-2k3-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > On Tue, Oct 13, 2015 at 10:30:08PM +0200, Arnd Bergmann wrote:
> > > The second argument of the mutex_lock_nested() helper is only
> > > evaluated if CONFIG_DEBUG_LOCK_ALLOC is set. Otherwise we
> > > get this build warning for the new regulator_lock_supply
> > > function:
> > > 
> > > drivers/regulator/core.c: In function 'regulator_lock_supply':
> > > drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable]
> > > 
> > > To avoid the warning, this patch changes the definition of
> > > mutex_lock_nested() to be static inline function rather than
> > > a macro, which tells gcc that the variable is potentially
> > > used.

Uuh, I just looked at next and saw this regulator_lock_supply()
function. How is that limited? subclass must be <8 otherwise bad things
happen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] mutex: make mutex_lock_nested an inline function Peter Zijlstra <peterz@infradead.org> - 2015-10-13 22:40 +0200
  Re: [PATCH] mutex: make mutex_lock_nested an inline function Arnd Bergmann <arnd@arndb.de> - 2015-10-13 23:50 +0200
    Re: [PATCH] mutex: make mutex_lock_nested an inline function Peter Zijlstra <peterz@infradead.org> - 2015-10-14 10:30 +0200
      Re: [PATCH] mutex: make mutex_lock_nested an inline function Peter Zijlstra <peterz@infradead.org> - 2015-10-14 10:40 +0200
        Re: [PATCH] mutex: make mutex_lock_nested an inline function Arnd Bergmann <arnd@arndb.de> - 2015-10-14 11:10 +0200
          Re: [PATCH] mutex: make mutex_lock_nested an inline function Peter Zijlstra <peterz@infradead.org> - 2015-10-14 11:10 +0200
            Re: [PATCH] mutex: make mutex_lock_nested an inline function Mark Brown <broonie@kernel.org> - 2015-10-14 12:10 +0200
      Re: [PATCH] mutex: make mutex_lock_nested an inline function Mark Brown <broonie@kernel.org> - 2015-10-14 12:30 +0200
        Re: [PATCH] mutex: make mutex_lock_nested an inline function Peter Zijlstra <peterz@infradead.org> - 2015-10-14 13:10 +0200
          Re: [PATCH] mutex: make mutex_lock_nested an inline function Mark Brown <broonie@kernel.org> - 2015-10-14 14:40 +0200
            Re: [PATCH] mutex: make mutex_lock_nested an inline function Peter Zijlstra <peterz@infradead.org> - 2015-10-14 15:50 +0200
              Re: [PATCH] mutex: make mutex_lock_nested an inline function Peter Zijlstra <peterz@infradead.org> - 2015-10-14 16:00 +0200
                Re: [PATCH] mutex: make mutex_lock_nested an inline function Ingo Molnar <mingo@kernel.org> - 2015-10-14 16:00 +0200
              Re: [PATCH] mutex: make mutex_lock_nested an inline function Mark Brown <broonie@kernel.org> - 2015-10-14 16:20 +0200

csiph-web